[
https://issues.apache.org/jira/browse/WW-5774?focusedWorklogId=1051779&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1051779
]
ASF GitHub Bot logged work on WW-5774:
--------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/26 21:35
Start Date: 01/Nov/26 21:35
Worklog Time Spent: 10m
Work Description: emilhuseyn commented on PR #2074:
URL: https://github.com/apache/struts/pull/2074#issuecomment-6564218981
Thanks, you're right that matching by name can't tell the pair apart.
Switched to id-based resolution: the select now carries
`data-struts-combobox-target-id` (the text field's id) and `combobox.js`
resolves it with `document.getElementById`, so two same-name comboboxes, and a
same-named hidden input placed earlier, no longer cross-write. The
`RadioNodeList` handling is gone. Added `ComboBox-6.txt` with two `name="tag"`
comboboxes, each pinned to its own id.
Description updated: corrected the data attribute, moved the `autoPopulate_`
migration paragraph into it, and noted `data-struts-combobox` stays as a public
styling/scripting hook. `ComboBoxTest` is 14/14 and the full `core` suite
passes on JDK 21. Thanks for filing WW-5835 for the `<script src>` de-dup; I'll
add the migration paragraph to the WW-5774 ticket as well.
Issue Time Tracking
-------------------
Worklog Id: (was: 1051779)
Time Spent: 50m (was: 40m)
> Move combobox change handling into a static script with a delegated listener
> ----------------------------------------------------------------------------
>
> Key: WW-5774
> URL: https://issues.apache.org/jira/browse/WW-5774
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Tags
> Reporter: Lukasz Lenart
> Priority: Major
> Fix For: 7.5.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> h2. Problem
> After WW-5772 the transfer-select and updownselect tags bind their buttons
> from a static script through one delegated listener. The combobox tag removes
> its inline {{onChange}} too, but it does so by emitting a per-instance inline
> script block (through the {{s.script}} directive, so it carries the nonce)
> that binds every select marked with {{data-struts-combobox}}.
> That leaves three issues:
> * A Content-Security-Policy based on script hashes or on static scripts only
> still blocks the combobox, while the transfer selects work under it.
> * The binding block is duplicated verbatim in
> {{template/simple/combobox.ftl}} and {{template/html5/combobox.ftl}}, so any
> change has to be made twice.
> * N comboboxes rendered in an iterator emit N script blocks, each scanning
> the page with {{querySelectorAll}}, plus N redefinitions of the
> {{autoPopulate_}} function.
> h2. Proposal
> Add a static {{combobox.js}} with a single delegated {{change}} listener that
> reads the target field from data attributes on the select, matching the
> approach WW-5772 uses for the transfer selects. The templates then emit no
> per-instance inline script.
> Related: WW-5772
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
