[jira] [Work logged] (WW-5836) Number tag and localized text arguments do not bound integer digits when formatting BigDecimal

[ASF GitHub Bot (Jira) via issues]

     [ 
https://issues.apache.org/jira/browse/WW-5836?focusedWorklogId=1052240&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1052240
 ]

ASF GitHub Bot logged work on WW-5836:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Nov/26 19:28
            Start Date: 03/Nov/26 19:28
    Worklog Time Spent: 10m 
      Work Description: sonarqubecloud[bot] commented on PR #2096:
URL: https://github.com/apache/struts/pull/2096#issuecomment-6613461227

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=2096) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [1 New 
issue](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=2096&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=2096&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=2096&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [95.4% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=2096&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=2096&metric=new_duplicated_lines_density&view=list)
  
     
   <!

Issue Time Tracking
-------------------

    Worklog Id:     (was: 1052240)
    Time Spent: 0.5h  (was: 20m)

> Number tag and localized text arguments do not bound integer digits when 
> formatting BigDecimal
> ----------------------------------------------------------------------------------------------
>
>                 Key: WW-5836
>                 URL: https://issues.apache.org/jira/browse/WW-5836
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>            Priority: Major
>             Fix For: 6.13.0, 7.5.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> WW-5828 bounded the number of integer digits {{StringConverter}} emits when 
> it formats a {{BigDecimal}}, falling back to {{BigDecimal.toString()}} past 
> the bound so that the length of the output follows the precision of the value 
> rather than its scale.
> Two other places in core format a {{BigDecimal}} without going through 
> {{StringConverter}}, and neither applies the same bound:
> * the {{number}} tag formats the value it finds on the stack with 
> {{NumberFormat}} directly;
> * message arguments passed to {{getText(key, args)}} (also reached from the 
> {{text}} tag with {{param}}, and from validator {{messageParams}}) are 
> formatted by {{MessageFormat}}, which delegates numeric arguments to the 
> locale {{NumberFormat}}.
> Apply the WW-5828 bound to both paths, sharing the bound rather than 
> duplicating the constant. For message arguments the bound has to be applied 
> through the formatter, not by substituting the argument, since a number-typed 
> message element rejects a {{String}} argument. Values within the bound must 
> render byte-identically to today, including {{currency}} and typed message 
> elements.
> Same fix on the 6.x line.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)