[
https://issues.apache.org/jira/browse/SVN-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Foad updated SVN-4020:
-----------------------------
Component/s: (was: src)
libsvn_auth_gnome_keyring
> libsvn_auth_gnome_keyring unnecessarily calling dbus
> ----------------------------------------------------
>
> Key: SVN-4020
> URL: https://issues.apache.org/jira/browse/SVN-4020
> Project: Subversion
> Issue Type: Bug
> Components: libsvn_auth_gnome_keyring
> Affects Versions: 1.6.x
> Environment: Linux
> Reporter: Subversion Importer
> Priority: Major
> Fix For: unscheduled
>
>
> {noformat:nopanel=true}
> This issues relates to #3581, in that the current implementation of the svn
> client (e.g., v1.6.17) prevents the use of the Gnome keyring for storing and
> retrieving encrypted passwords when a dbus session does not exist. The
> specific
> cause are these lines in gnome_keyring.c:
> if (! dbus_bus_get(DBUS_BUS_SESSION, NULL))
> {
> return FALSE;
> }
> This then precludes using the svn client as a command-line tool via an ssh
> terminal on a system where the Gnome desktop is not running. Thus for such
> users, of which there are many, the only option is to store the password in
> plain text or not to store it at all.
> The CollabNet release of this same version of the svn client has this code
> removed, and the configure script has been changed to not require dbus when
> building with the --with-gnome-keyring option. This build of the client works
> perfectly well, since the gnome-keyring-daemon and its library do not require
> dbus, nor even having X11 running. I have tested the stock release of the
> client v1.6.17 with this code commented out, and it also works correctly.
> The gnome-keyring-daemon needs to have been previously started, and if the
> keyring is locked when the svn client is invoked for the first time, the user
> gets a command line prompt to enter the keyring password. Thereafter for as
> long as the daemon is running, it works as expected, retrieving the stored
> password, or storing it if it is not present or valid in the keyring.
> I would request that these lines be removed from gnome_keyring.c (they appear
> twice: both for getting and setting a password).
> They perhaps should also be removed from kwallet.cpp, but I have not tested
> whether dbus is required by kwallet.
> Thanks,
> Dennis
> {noformat}
> Original issue reported by *dmcritchie*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
