[
https://issues.apache.org/jira/browse/SYSTEMML-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240119#comment-15240119
]
Matthias Boehm commented on SYSTEMML-495:
-----------------------------------------
in general, I'm fine with Mike's proposal - just one minor tweak: let's always
start with the internal defaults, any specified or default configuration file
replaces values of specified configurations. This gets rid of the actual file
merge but still ensures that we always have a complete set of configurations.
There are tons of "old" configuration files used all over the place and these
are usually not updated with new versions of SystemML.jar. Always relying on
the internal defaults would provide a good level of robustness here.
> Simplify SystemML Configuration Loading
> ---------------------------------------
>
> Key: SYSTEMML-495
> URL: https://issues.apache.org/jira/browse/SYSTEMML-495
> Project: SystemML
> Issue Type: Improvement
> Reporter: Mike Dusenberry
> Assignee: Mike Dusenberry
> Priority: Minor
>
> Currently, SystemML always looks for a configuration file in a default
> location (in the current directory), and will always emit a warning if it is
> not found. Additionally, SystemML allows a user to supply a configuration
> file location. In this latter case, SystemML will still attempt to read the
> default configuration file, emitting a warning if it is not present (which
> causes confusion), as well as the user-supplied file. If both are loaded,
> the user-supplied file will be merged into the default configuration with an
> overwrite strategy.
> Always looking for a default file, even when a file is explicitly supplied,
> causes confusion, and may create unintended side effects. If a user
> explicitly supplies a configuration file, we should simply use that file,
> rather than attempting to also read an additional default file at the same
> time. In order to provide backwards compatibility, if the user does not
> supply a file, then we should fall back to the default file location. If
> that file is also not found, we should then fall back to the internal
> defaults.
> Additionally, in order to supply an additional configuration file, the
> {{-config=path/to/file}} flag has to be used, and it only works with the
> equals sign {{=}} present, which is unlike all other flags that use spaces.
> Instead, we should support {{-config path/to/file}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
