[
https://issues.apache.org/jira/browse/SYSTEMML-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930471#comment-15930471
]
Mike Dusenberry commented on SYSTEMML-1406:
-------------------------------------------
Strong -1 on tabs.
People attempt to use tabs to line up code & docs, and in the process, just
cause more problems. This leads to messy code such as [this entire section|
https://github.com/apache/incubator-systemml/blob/master/scripts/algorithms/bivar-stats.dml#L84],
[this|
https://github.com/apache/incubator-systemml/blob/master/scripts/algorithms/bivar-stats.dml#L190],
[this|
https://github.com/apache/incubator-systemml/blob/master/scripts/algorithms/Cox-predict.dml#L43],
[this|
https://github.com/apache/incubator-systemml/blob/master/scripts/algorithms/GLM.dml#L608],
[this|
https://github.com/apache/incubator-systemml/blob/master/scripts/algorithms/stratstats.dml#L263],
[this (Java)|
https://github.com/apache/incubator-systemml/blob/master/src/main/java/org/apache/sysml/hops/AggBinaryOp.java#L646],
[this (Java)|
https://github.com/apache/incubator-systemml/blob/master/src/main/java/org/apache/sysml/api/DMLScript.java#L850],
etc.
Spaces never have this problem due to the size of a space in being
deterministic in comparison to any other character in a monospaced font.
I'm 100% in favor of standardizing our DML to spaces, with 2-space indention,
and 4-space continuation lines, all of which is pretty common. The SystemML-NN
library already uses this format consistently.
> Fix whitespace issues in main algorithms
> ----------------------------------------
>
> Key: SYSTEMML-1406
> URL: https://issues.apache.org/jira/browse/SYSTEMML-1406
> Project: SystemML
> Issue Type: Improvement
> Components: Algorithms
> Reporter: Deron Eriksson
> Assignee: Deron Eriksson
>
> 1) The main algorithms in scripts/algorithms use both spaces and tabs, which
> can lead to readability issues when looking at the scripts in an environment
> such as GitHub. See
> https://github.com/apache/incubator-systemml/tree/master/scripts/algorithms.
> We should convert tabs to spaces and format accordingly to improve script
> readability.
> 2) Remove trailing whitespace since git does not like it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
