[
https://issues.apache.org/jira/browse/SYSTEMML-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951762#comment-15951762
]
Matthias Boehm commented on SYSTEMML-1449:
------------------------------------------
and it needs to be there because otherwise the subsequent check could run into
an index-out-of-bounds
> Potential bug in compare method
> -------------------------------
>
> Key: SYSTEMML-1449
> URL: https://issues.apache.org/jira/browse/SYSTEMML-1449
> Project: SystemML
> Issue Type: Bug
> Reporter: JC
> Priority: Minor
>
> Hi
> In recent github mirror, I've found the following issue.
> Path: src/main/java/org/apache/sysml/hops/QuaternaryOp.java
> {code:java}
> 1566
> 1567 //compare basic inputs and weights (always existing)
> 1568 boolean ret = (_op == that2._op
> 1569 && getInput().size() == getInput().size()
> 1570 && getInput().get(0) ==
> that2.getInput().get(0)
> 1571 && getInput().get(1) ==
> that2.getInput().get(1)
> 1572 && getInput().get(2) ==
> that2.getInput().get(2) );
> 1573
> {code}
> Line 1569 should be like this? Or, removing the line is just OK?
> {code}
> 1569 && getInput().size() ==
> that2.getInput().size()
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
