[ 
https://issues.apache.org/jira/browse/TAJO-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948820#comment-13948820
 ] 

David Chen commented on TAJO-30:
--------------------------------

Ah good catch. The actual default block size is 128 MB according to the current 
parquet-mr sources 
(https://github.com/Parquet/parquet-mr/blob/8cc3e29cc28896cfd47c90abec97f1aa866832c1/parquet-hadoop/src/main/java/parquet/hadoop/ParquetWriter.java).
 I adapted that comment from parquet-avro's {{AvroParquetWriter}}, which was 
probably not updated when the default block size is changed.

I believe the patch file for my third revision for fixing the Javadoc comments 
also includes all of the other changes as well. I can easily post a new patch 
that fixes this comment as well, or I can fix that comment in a future patch, 
such as for TAJO-714. What works best for you?

> Parquet Integration
> -------------------
>
>                 Key: TAJO-30
>                 URL: https://issues.apache.org/jira/browse/TAJO-30
>             Project: Tajo
>          Issue Type: New Feature
>            Reporter: Hyunsik Choi
>            Assignee: David Chen
>              Labels: Parquet
>         Attachments: TAJO-30.patch, TAJO-30_20140326_05:06:57.patch, 
> TAJO-30_20140326_05:34:17.patch, null_handling.patch
>
>
> Parquet is a columnar storage format developed by Twitter. Implement Parquet 
> (http://parquet.io/) support for Tajo.
> The implementation consists of the following:
>  * {{ParquetScanner}} and {{ParquetAppender}} - FileScanner and FileAppenders 
> for reading and writing Parquet.
>  * {{TajoParquetReader}} and {{TajoParquetWriter}} - Top-level reader and 
> writer for serializing/deserializing to Tajo Tuples.
>  * {{TajoReadSupport}} and {{TajoWriteSupport}} - Abstractions to perform 
> conversion between Parquet and Tajo records.
>  * {{TajoRecordMaterializer}} - Materializes Tajo Tuples from Parquet's 
> internal representation.
>  * {{TajoRecordConverter}} - Used by {{TajoRecordMateriailzer}} to 
> materialize a Tajo Tuple.
>  * {{TajoSchemaConverter}} - Converts between Tajo and Parquet schemas.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to