-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20074/
-----------------------------------------------------------
Review request for Tajo.
Bugs: TAJO-738
https://issues.apache.org/jira/browse/TAJO-738
Repository: tajo
Description
-------
If making plan in the QueryMaster, the bellow error message is shown in
QueryMaster's log.
{noformat}
2014-04-07 10:11:33,090 INFO [QueryMasterClientProtocol-1 Server Worker #2]
worker.TajoWorkerClientService (TajoWorkerClientService.java:closeQuery(211)) -
Stop Query:q_1396833048200_0002
java.lang.NullPointerException
at
org.apache.tajo.master.querymaster.QueryMaster.buildTajoHeartBeat(QueryMaster.java:364)
at
org.apache.tajo.master.querymaster.QueryMaster.access$800(QueryMaster.java:60)
at
org.apache.tajo.master.querymaster.QueryMaster$QueryHeartbeatThread.run(QueryMaster.java:408)
{noformat}
Also similar message shown in CLI.
{noformat}
2014-04-07 10:11:33,087 ERROR [TajoClient-1 Worker #0] rpc.RpcProtos
(BlockingRpcClient.java:exceptionCaught(215)) - RPC Exception:Exception
[org.apache.tajo.ipc.QueryMasterClientProtocol(192.168.0.159:28092)]:
java.lang.NullPointerException
at
org.apache.tajo.worker.TajoWorkerClientService$TajoWorkerClientProtocolServiceHandler.getQueryStatus(TajoWorkerClientService.java:190)
at
org.apache.tajo.ipc.QueryMasterClientProtocol$QueryMasterClientProtocolService$2.callBlockingMethod(QueryMasterClientProtocol.java:115)
at
org.apache.tajo.rpc.BlockingRpcServer$ServerHandler.messageReceived(BlockingRpcServer.java:103)
at
org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:296)
at
org.jboss.netty.handler.codec.oneone.OneToOneDecoder.handleUpstream(OneToOneDecoder.java:70)
at
org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:296)
at
org.jboss.netty.handler.codec.frame.FrameDecoder.unfoldAndFireMessageReceived(FrameDecoder.java:462)
at
org.jboss.netty.handler.codec.frame.FrameDecoder.callDecode(FrameDecoder.java:443)
at
org.jboss.netty.handler.codec.frame.FrameDecoder.messageReceived(FrameDecoder.java:303)
at
org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:268)
at
org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:255)
at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:88)
at
org.jboss.netty.channel.socket.nio.AbstractNioWorker.process(AbstractNioWorker.java:107)
at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:312)
at
org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:88)
at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
{noformat}
Diffs
-----
tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java 426c115
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMaster.java
abdc214
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java
79b4a08
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoWorkerClientService.java
a73623f
tajo-core/tajo-core-backend/src/main/resources/webapps/admin/query.jsp
c1fccb8
tajo-core/tajo-core-backend/src/main/resources/webapps/worker/index.jsp
1150ade
tajo-core/tajo-core-backend/src/main/resources/webapps/worker/querydetail.jsp
2d867ed
Diff: https://reviews.apache.org/r/20074/diff/
Testing
-------
mvn clean install.
I'm sorry that I can't make test code. Because it is difficult to inject error
case in QueryMasterTask or GlobalPlanner.
Thanks,
hyoungjun kim
