----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20198/#review39994 -----------------------------------------------------------
Ship it! +1 Looks great! I've verified 'mvn clean install'. - Jinho Kim On April 10, 2014, 5:20 a.m., Hyunsik Choi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20198/ > ----------------------------------------------------------- > > (Updated April 10, 2014, 5:20 a.m.) > > > Review request for Tajo. > > > Bugs: TAJO-563 > https://issues.apache.org/jira/browse/TAJO-563 > > > Repository: tajo > > > Description > ------- > > INSERT OVERWRITE removes a table data set regardless of query success. In > addition, INSERT OVERWRITE removes a table data set upon launching a query. > It is a very dangerous approach, and we have to fix it. > > > Diffs > ----- > > CHANGES.txt a83dd255fee8972cdd10457f326fa658d1044d02 > tajo-common/src/main/java/org/apache/tajo/TajoConstants.java > 61eecd1553c4616b126c2d4d5164c5e73c3e8064 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java > 3a4df7b9aca81a0d3962f34a76ca4b114c489d2a > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java > 271eaf9a6765b6121fadadcedb69165052021df6 > > Diff: https://reviews.apache.org/r/20198/diff/ > > > Testing > ------- > > > Thanks, > > Hyunsik Choi > >
