> On April 15, 2014, 7:36 a.m., Hyunsik Choi wrote: > > There is another suggestion. Hive 0.11 may be not available because > > HCatalogStore already uses Timestamp and Date types introduced in 0.12. So, > > I propose the removal of Hive 0.11 dependency from tajo-hcatalog.
Thank you for the review. I will upload the patch that reflects your suggestion. - Jinho ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20304/#review40356 ----------------------------------------------------------- On April 14, 2014, 12:01 p.m., Jinho Kim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20304/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 12:01 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-753 > https://issues.apache.org/jira/browse/TAJO-753 > > > Repository: tajo > > > Description > ------- > > Maven pom files include many dependencies. Some of the dependencies are not > necessary, and others should be changed as {{provided}}. The main objective > of this issue is to clean up maven dependencies. > > > Diffs > ----- > > tajo-algebra/pom.xml 2f91b8560c89a931264aa21824247d4b3ab43485 > tajo-catalog/tajo-catalog-client/pom.xml > b511739ad03afc66db55453120ba4571739a3f33 > tajo-catalog/tajo-catalog-common/pom.xml > fa902376d03af8a0d557975ea300b73f14e3af3d > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java > 8cad4fe946a836d43df00b468622ae239bc703b1 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java > 755532575621ce6ffcffcf8c37b2b16297d31e1b > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/pom.xml > 86ba34341245818bfa62cdf5c568f8d265e30454 > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java > 0fe255cf969088c933acc782d9226f25458d099f > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java > f4ca4d1c62fad63bf4170bbdeef614e6cf1aea55 > tajo-catalog/tajo-catalog-server/pom.xml > 03e92ec93a3b431d874d1834717d50a308a9bdc5 > tajo-client/pom.xml c6fbb27840c7138fb77572266f87439156223371 > tajo-common/pom.xml 00e2448959f60a644073897b4a496b0c861d924f > tajo-common/src/test/java/org/apache/tajo/datum/TestInt2Datum.java > 832f5634d342a4c8cdfbbeb31019252f73be287b > tajo-core/pom.xml e131d0e9f01be5332a27c35dfd68df7172b3df8a > tajo-core/tajo-core-backend/pom.xml > 1a67fa72866bb56baad91773f053d0bba112befb > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/benchmark/TPCH.java > 5dd0b1216a7cbdc69f524932cb89186c7780d010 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java > f28f7ca814cad3006cb370a1a443c6d7e46f5059 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java > 8946c026ad47984b37e74512c8d0669ab2df784c > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TpchTestBase.java > 8487e845f0ce539f72a70c86b22f000ace54b0cd > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestDDLBuilder.java > 9d8d631fc9ae3a73490f86f5bd3a70997216bb13 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java > 4dc57288424e871ac2e0659299fc886e46cf3ffb > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNullValues.java > c460bcfe6ce38063f2b0a634fd8ec7bc0660148e > tajo-core/tajo-core-pullserver/pom.xml > b5049befcc0ee61e11f34a63e27c58899dac615b > > tajo-core/tajo-core-pullserver/src/main/hadoop-2.2.0/org/apache/tajo/pullserver/FadvisedFileRegionWrapper.java > PRE-CREATION > > tajo-core/tajo-core-pullserver/src/main/hadoop-2.2.0/org/apache/tajo/pullserver/listener/FileCloseListener.java > b7f3e34a7c38dadacf51a7e463ebd98ec1b18b09 > > tajo-core/tajo-core-pullserver/src/main/hadoop-2.3.0/org/apache/tajo/pullserver/FadvisedFileRegionWrapper.java > PRE-CREATION > > tajo-core/tajo-core-pullserver/src/main/hadoop-2.4.0/org/apache/tajo/pullserver/FadvisedFileRegionWrapper.java > PRE-CREATION > > tajo-core/tajo-core-pullserver/src/main/hadoop-2.4.0/org/apache/tajo/pullserver/listener/FileCloseListener.java > PRE-CREATION > > tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java > 40978fe71d880ceebedff61e4d4d0d9a0c99bc0c > > tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java > 70f542187a7e5de93a25452c57653dfe2caa2287 > tajo-jdbc/pom.xml d691af7c7c8f568d523a5e793e84657ee554e12c > tajo-project/pom.xml 6a2ff2608afcf25f5fdec8aab65a9d518c27f843 > tajo-rpc/pom.xml 7f7ae79b64f756364e14547d31203221c84c4637 > tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java > 214a4ba400fdb4c3c302093e1ac56fb8dbd590f5 > tajo-storage/pom.xml 5850ed46a5c1064cfb1fab629234739437cd114f > > tajo-storage/src/main/java/org/apache/tajo/storage/AbstractStorageManager.java > 661520879e6488d44463b843c0be1329af7b7574 > tajo-storage/src/main/java/org/apache/tajo/storage/CSVFile.java > 857278ad045d3c527c02694d41d109d8b61a561a > tajo-storage/src/main/java/org/apache/tajo/storage/StorageConstants.java > PRE-CREATION > tajo-storage/src/main/java/org/apache/tajo/storage/StorageUtil.java > 1f139468975c8b38857f4695e103daafd950b720 > tajo-storage/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java > 1beea991cc7f023d89e015b9a48031fe2a798edf > > tajo-storage/src/main/java/org/apache/tajo/storage/sequencefile/SequenceFileAppender.java > 8092c0c38e009bb6be0bab2c124e6fbb6c358c04 > > tajo-storage/src/main/java/org/apache/tajo/storage/sequencefile/SequenceFileScanner.java > c5720e3ce17b0a6cd5a9154c39b48ea6465c628d > tajo-storage/src/test/java/org/apache/tajo/storage/TestMergeScanner.java > 354fbc2bc4922dbcfa128690859a815751dcbc62 > tajo-storage/src/test/java/org/apache/tajo/storage/TestStorageManager.java > be8b6de93b487a5f72278085f15a9cf94c53c3c0 > tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java > a500f0976ae8fdc1a14e4da9e6a432840672fc50 > tajo-storage/src/test/java/org/apache/tajo/storage/v2/TestStorages.java > 140aa0937404e714ac4fafa8ea1000ef5fb47196 > > Diff: https://reviews.apache.org/r/20304/diff/ > > > Testing > ------- > > mvn clean package -Pdist -Dtar -Dhadoop.version=2.2.0 -Phcatalog-0.12.0 > mvn clean package -Pdist -Dtar -Dhadoop.version=2.3.0 -Phcatalog-0.12.0 > mvn clean package -Pdist -Dtar -Dhadoop.version=2.4.0 -Phcatalog-0.12.0 > > > Thanks, > > Jinho Kim > >
