----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20545/#review40999 -----------------------------------------------------------
Ship it! +1 Thank you for your contribution. Push it. :) - Jung JaeHwa On April 22, 2014, 6:09 a.m., Hyunsik Choi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20545/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 6:09 a.m.) > > > Review request for Tajo. > > > Bugs: TAJO-786 > https://issues.apache.org/jira/browse/TAJO-786 > > > Repository: tajo > > > Description > ------- > > The parameter of MetaDataTuple should be 2 instead of 1. > > MetaDataTuple tuple = new MetaDataTuple(1); > tuple.put(0, new TextDatum(DEFAULT_SCHEMA_NAME)); > tuple.put(1, new TextDatum(databaseName)); > > > Diffs > ----- > > tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoDatabaseMetaData.java > 295a39f > tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java 7343ef7 > > tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getSchemas1.result > PRE-CREATION > > tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getSchemas2.result > PRE-CREATION > > tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getTableTypes.result > PRE-CREATION > > tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getTables1.result > 2d89f42 > > tajo-core/src/test/resources/results/TestTajoDatabaseMetaData/getTables2.result > 7cc1391 > tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java > cbdb38b > tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDriver.java ffab2dd > > Diff: https://reviews.apache.org/r/20545/diff/ > > > Testing > ------- > > mvn clean install > > > Thanks, > > Hyunsik Choi > >
