----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20831/#review41803 -----------------------------------------------------------
Ship it! +1 - Hyunsik Choi On April 30, 2014, 10:45 a.m., Jinho Kim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20831/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 10:45 a.m.) > > > Review request for Tajo. > > > Bugs: TAJO-605 > https://issues.apache.org/jira/browse/TAJO-605 > > > Repository: tajo > > > Description > ------- > > The name of Options class is not good for presenting its purpose. We should > rename Options to KeyValueList. Also, it is a general purpose rather than for > catalog. We need to move it to tajo-common. > > > Diffs > ----- > > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java > 1dd33b2a3e765c5aacb56b109cf29202583e9916 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java > 77dccd2ee1a67d5787fb4420b8c28bd3e15b5fb3 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java > c6f9a774cb7161b61eb5c967cd78004ece047520 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java > 5aa035e4ff4091ad27ee8b9ae6a09611105c27ae > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java > 6c72f58994609c6d196c44909e00832c262caf73 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java > b3f788e7786aedff56613341ea528eff7242fdaf > tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto > 7f415962bd98aecbebf11095a21e0d60be54f40a > > tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestOptions.java > bcccfd302cd6c140ee8e4b5a2d7025492b30ace3 > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java > e6f6accfab7034e0873a19f021b83c39fcf6b0d2 > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java > 0cb4520ff45eab9ada7b90650ab66bbeb83dd86d > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java > 234af19b3b7d872b25e24ebae7201b7fd93716cf > > tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java > 32ea83b0d48d96dc608e51dd7b6ab39e40efd452 > tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java > 3c85662eb9480bbcb17a72f804b8071c917289ce > tajo-common/src/main/proto/PrimitiveProtos.proto > 820f96c61dc9fd29064838683e8085952f9f9c18 > tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java > f2ddf13aa5046d3086299b9117f449bc25728dfb > > tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java > edc08fca17dfea6c454295e9d135ca991ced3673 > > tajo-core/src/main/java/org/apache/tajo/engine/planner/logical/CreateTableNode.java > c70fb102194b375a38c625c9ab6bf5717245d593 > > tajo-core/src/main/java/org/apache/tajo/engine/planner/logical/PersistentStoreNode.java > 9d2acf6fdf6d7a8b685b922d042dcade87f00eab > tajo-core/src/main/java/org/apache/tajo/engine/query/QueryContext.java > 44c4ddc3c87929ef762130409c9861f79c7b7555 > tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java > c6facb19f0decc72e89131138dae5d8e94e1fd77 > tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java > 921bb3a711beb72868ebe87b97f29dc99bd57776 > tajo-core/src/main/java/org/apache/tajo/master/session/Session.java > 4d244bf8646cb5812328028d31c0758318bae702 > tajo-core/src/test/java/org/apache/tajo/LocalTajoTestingUtility.java > e65131325d662b325c23cef0923e3765e9fd2948 > tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java > 010faa8f996b1049068b27f1174da3db90c4d55d > tajo-core/src/test/java/org/apache/tajo/TpchTestBase.java > 8995d81defcd0e3ce443c18f257736b4c4e723c3 > tajo-core/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java > d19b4d6d193cf65a3d60d7145855fe9a4d578ad3 > > tajo-core/src/test/java/org/apache/tajo/engine/planner/TestLogicalOptimizer.java > 5acd512c956078aade299a9ae83c296b31e3fa3b > > tajo-core/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java > b586f56cbe984376e92f57d637b29115d0483d65 > tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPlannerUtil.java > be4c1335544c32efac7446a9ca7bdcefff140e95 > > tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java > cee0cb073bd20203f1b5cfd04f69b2c43e362197 > tajo-core/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java > a4e31e052fbbb3d84fa1880e8a8d0bfc86a26cf2 > tajo-core/src/test/java/org/apache/tajo/engine/query/TestNullValues.java > c5afc3de638225c9a5d3b0f153de4a53a54a4ae8 > > tajo-core/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java > 686aa9ca34235b4a55fde8a20d52f1449dfe29ed > tajo-storage/src/main/java/org/apache/tajo/storage/StorageUtil.java > 2acae5af70c68be4aa5c8407a7bd643da0f5f532 > tajo-storage/src/test/java/org/apache/tajo/storage/TestMergeScanner.java > 5a4b09223ff22ae8081104dce84d747c28bf7e9a > tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java > 58508dd92cde02e00a5e08a5fd025b8e671c67bb > tajo-storage/src/test/java/org/apache/tajo/storage/v2/TestStorages.java > d6cfee364456d540d1a9cd0db06286ae72d9f278 > > Diff: https://reviews.apache.org/r/20831/diff/ > > > Testing > ------- > > > Thanks, > > Jinho Kim > >
