[
https://issues.apache.org/jira/browse/TAJO-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13991565#comment-13991565
]
Tajo QA commented on TAJO-812:
------------------------------
{color:red}*-1 overall.*{color} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12643691/TAJO-812.patch
against master revision 70567fc.
{color:green}+1 @author.{color} The patch does not contain any @author
tags.
{color:red}-1 tests included.{color} The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac.{color} The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc.{color} The applied patch does not increase the
total number of javadoc warnings.
{color:green}+1 checkstyle.{color} The patch generated 0 code style errors.
{color:red}-1 findbugs.{color} The patch appears to introduce 4 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit.{color} The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests.{color} The patch passed unit tests in
tajo-client tajo-jdbc tajo-rpc.
Test results:
https://builds.apache.org/job/PreCommit-TAJO-Build/413//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/413//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/413//console
This message is automatically generated.
> Some methods of TajoDatabaseMetaData should result in an empty tuple list
> instead of SQLFeatureNotSupportedException.
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: TAJO-812
> URL: https://issues.apache.org/jira/browse/TAJO-812
> Project: Tajo
> Issue Type: Bug
> Components: JDBC
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Priority: Minor
> Fix For: 0.9.0, 0.8.1
>
> Attachments: TAJO-812.patch
>
>
> There are some methods that Tajo cannot support. getPrimaryKeys,
> getExportedKeys, and getImportedKeys are examples. Currently, these methods
> cause SQLFeatureNotSupportedException. But, they should return an empty list
> instead of the exception. This patch fixes this problem.
> In addition, this patch fixes some potential deadlock problem in
> NettyClientBase and NettyServerBase.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
