[
https://issues.apache.org/jira/browse/TAJO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999585#comment-13999585
]
Tajo QA commented on TAJO-821:
------------------------------
{color:red}*-1 overall.*{color} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12644795/TAJO-821.patch
against master revision 9350a80.
{color:green}+1 @author.{color} The patch does not contain any @author
tags.
{color:red}-1 tests included.{color} The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac.{color} The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc.{color} The applied patch does not increase the
total number of javadoc warnings.
{color:green}+1 checkstyle.{color} The patch generated 0 code style errors.
{color:green}+1 findbugs.{color} The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit.{color} The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests.{color} The patch passed unit tests in tajo-rpc.
Test results:
https://builds.apache.org/job/PreCommit-TAJO-Build/426//testReport/
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/426//console
This message is automatically generated.
> IllegalStateException occurs when a NettyClientBase object is created within
> single thread.
> -------------------------------------------------------------------------------------------
>
> Key: TAJO-821
> URL: https://issues.apache.org/jira/browse/TAJO-821
> Project: Tajo
> Issue Type: Bug
> Reporter: Hyoungjun Kim
> Assignee: Hyoungjun Kim
> Priority: Minor
> Attachments: TAJO-821.patch
>
>
> When I created a TajoClient instance which uses a NettyClientBase on a
> TajoMaster's RPC handler, the following exception occurs.
> {noformat}
> java.lang.IllegalStateException: await*() in I/O thread causes a dead lock or
> sudden performance drop. Use addListener() instead or call await*() from a
> different thread.
> at
> org.jboss.netty.channel.DefaultChannelFuture.checkDeadLock(DefaultChannelFuture.java:343)
> at
> org.jboss.netty.channel.DefaultChannelFuture.await0(DefaultChannelFuture.java:307)
> at
> org.jboss.netty.channel.DefaultChannelFuture.await(DefaultChannelFuture.java:248)
> at
> com.cloudhopper.smpp.impl.DefaultSmppClient.createConnectedChannel(DefaultSmppClient.java:266)
> at
> com.cloudhopper.smpp.impl.DefaultSmppClient.doOpen(DefaultSmppClient.java:216)
> at
> com.cloudhopper.smpp.impl.DefaultSmppClient.bind(DefaultSmppClient.java:185)
> {noformat}
> There is some issues about this error in Netty 3.6. Check the following url.
> https://community.jboss.org/thread/221243
> This issue can be resolved by setting the deadLockChecker to false.
> {code}
> DefaultChannelFuture.setUseDeadLockChecker(false);
> {code}
> But this solution is to have a potential problem. So I suggest that
> NettyClientBase uses ChannelFutureListener.operationComplete() instead of
> awaitUninterruptibly()
--
This message was sent by Atlassian JIRA
(v6.2#6252)
