[
https://issues.apache.org/jira/browse/TAJO-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008705#comment-14008705
]
Tajo QA commented on TAJO-848:
------------------------------
{color:red}*-1 overall.*{color} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12646765/TAJO-848.patch
against master revision 5bdfe88.
{color:green}+1 @author.{color} The patch does not contain any @author
tags.
{color:green}+1 tests included.{color} The patch appears to include 3 new
or modified test files.
{color:green}+1 javac.{color} The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc.{color} The applied patch does not increase the
total number of javadoc warnings.
{color:green}+1 checkstyle.{color} The patch generated 0 code style errors.
{color:red}-1 findbugs.{color} The patch appears to introduce 192 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit.{color} The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests.{color} The patch failed these unit tests in
tajo-core:
org.apache.tajo.engine.eval.TestSQLExpression
Test results:
https://builds.apache.org/job/PreCommit-TAJO-Build/432//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/432//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/432//console
This message is automatically generated.
> PreLogicalPlanVerifier::visitInsert need to find smaller expressions than
> target columns for a partitioned table.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: TAJO-848
> URL: https://issues.apache.org/jira/browse/TAJO-848
> Project: Tajo
> Issue Type: Bug
> Components: planner/optimizer
> Reporter: Jaehwa Jung
> Assignee: Jaehwa Jung
> Fix For: 0.9.0, 0.8.1
>
> Attachments: TAJO-848.patch
>
>
> Currently, user can insert data even if there is small columns compare to
> target columns as follows:
> {code:xml}
> create table table1 (id int, name text, score float, type text) using csv
> with ('csvfile.delimiter'='|') ;
> create table table3 (id int, name text, score float, type text) using csv
> with ('csvfile.delimiter'='|') ;
> create table table4 (id int, name text, score float, type text) using csv
> with ('csvfile.delimiter'='|') partition by column(part text);
> default> insert overwrite into table3 select id, name from table1;
> Progress: 0%, response time: 0.544 sec
> Progress: 100%, response time: 1.158 sec
> (5 rows, 1.158 sec, 60 B inserted)
> default> insert overwrite into table4 select id, name from table1;
> Progress: 100%, response time: 0.468 sec
> (5 rows, 0.468 sec, 65 B inserted)
> {code}
> As above, tajo can run a query for inserting data. But in partitioned table,
> tajo made null value for partition column as follows:
> {code:xml}
> hdfs dfs -ls /tajo/warehouse/default/table4
> Found 1 items
> drwxr-xr-x - blrunner supergroup 0 2014-05-26 16:27
> /tajo/warehouse/default/table4/part=
> {code}
> Thus we need to make a syntax exception for blocking null partition value.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
