Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/16#discussion_r13055130
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java ---
@@ -947,14 +947,15 @@ public Expr
visitNumeric_value_function(Numeric_value_functionContext ctx) {
@Override
public Expr visitExtract_expression(Extract_expressionContext ctx) {
Expr extractTarget = new
LiteralValue(ctx.extract_field_string.getText(), LiteralType.String);
- Expr extractSource;
- if (checkIfExist(ctx.extract_source().column_reference())) {
- extractSource =
visitColumn_reference(ctx.extract_source().column_reference());
- } else if (checkIfExist(ctx.extract_source().datetime_literal())) {
- extractSource =
visitDatetime_literal(ctx.extract_source().datetime_literal());
- } else {
- return null;
- }
+ Expr extractSource =
visitDatetime_value_expression(ctx.extract_source().datetime_value_expression());
+// if (checkIfExist(ctx.extract_source().column_reference())) {
--- End diff --
They seem to be obsolete code. I'll remove them before commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
