Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/21#issuecomment-44229679
Hi Prafulla,
I reviewed your patch in more detail. Excellent! You work is very nice. It
works well. I leave only some trivial comments.
Although we do not use maven checkstyle plugin to strictly check coding
convention, we already use some coding style. Please take a look at this [1].
We use 2 space instead of tab. Other conventions you use look nice to me.
In addition, it would be better if you use ```assertTrue(message : string,
condition:boolean)``` and ```assertEquals(message : string, obj1:Object,
obj2:Object)``` instead of using ```System.out.println``` in
```isClonedSchema```. It usually generates more comprehensive output messages
in the tail of maven message when the test is failed.
* [1] https://cwiki.apache.org/confluence/display/TAJO/Code+Style
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
