[
https://issues.apache.org/jira/browse/TAJO-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009224#comment-14009224
]
ASF GitHub Bot commented on TAJO-699:
-------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/21#issuecomment-44229679
Hi Prafulla,
I reviewed your patch in more detail. Excellent! You work is very nice. It
works well. I leave only some trivial comments.
Although we do not use maven checkstyle plugin to strictly check coding
convention, we already use some coding style. Please take a look at this [1].
We use 2 space instead of tab. Other conventions you use look nice to me.
In addition, it would be better if you use ```assertTrue(message : string,
condition:boolean)``` and ```assertEquals(message : string, obj1:Object,
obj2:Object)``` instead of using ```System.out.println``` in
```isClonedSchema```. It usually generates more comprehensive output messages
in the tail of maven message when the test is failed.
* [1] https://cwiki.apache.org/confluence/display/TAJO/Code+Style
> Create a table using LIKE
> -------------------------
>
> Key: TAJO-699
> URL: https://issues.apache.org/jira/browse/TAJO-699
> Project: Tajo
> Issue Type: Improvement
> Components: catalog, parser, planner/optimizer
> Reporter: Jaehwa Jung
> Assignee: Prafulla T
> Attachments: TAJO-699.patch
>
>
> Creating a table from existing table is very useful function for users. So,
> we should support CREATE TABLE LIKE The grammar is as follows:
> {code:xml}
> CREATE TABLE <table_name> LIKE <source_table_name>
> {code}
> For reference, the LIKE clause specifies a table from which the new table
> automatically copies all column names, their data types.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
