----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21719/#review44472 -----------------------------------------------------------
Hi Jaehwa, sorry for late review. This patch looks gone stale. Please update it. Thanks. - Jihoon Son On May 21, 2014, 2:52 a.m., Jung JaeHwa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21719/ > ----------------------------------------------------------- > > (Updated May 21, 2014, 2:52 a.m.) > > > Review request for Tajo. > > > Bugs: TAJO-784 > https://issues.apache.org/jira/browse/TAJO-784 > > > Repository: tajo > > > Description > ------- > > Currently, tajo provides TpchTestBase for TPC-H benchmark. But it is > inefficient because it uses all queries which was written in java code. Other > test cases use queries which was written in query file. Thus we should > refactor it to extend QueryTestCaseBase. In addition, we need to add more > TPC-H queries. > > > Diffs > ----- > > tajo-core/benchmark/tpch/customer.schema 9df7c38 > tajo-core/benchmark/tpch/lineitem.schema c90c11e > tajo-core/benchmark/tpch/nation.schema 7dd9623 > tajo-core/benchmark/tpch/orders.schema 62cb45b > tajo-core/benchmark/tpch/part.schema dad053b > tajo-core/benchmark/tpch/partsupp.schema 4732392 > tajo-core/benchmark/tpch/region.schema e9a0057 > tajo-core/benchmark/tpch/supplier.schema 4fca98b > tajo-core/src/test/java/org/apache/tajo/LocalTajoTestingUtility.java > 84522e1 > tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java 1d6ee86 > tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java 011ed07 > tajo-core/src/test/java/org/apache/tajo/TestBase.java PRE-CREATION > tajo-core/src/test/java/org/apache/tajo/TpchTestBase.java 5ed8821 > > tajo-core/src/test/java/org/apache/tajo/cli/TestExecExternalShellCommand.java > 8017dc6 > tajo-core/src/test/java/org/apache/tajo/cli/TestHdfsCommand.java b51835f > tajo-core/src/test/java/org/apache/tajo/cli/TestTajoCli.java b3fbda4 > tajo-core/src/test/java/org/apache/tajo/client/TestTajoClient.java 49e6874 > tajo-core/src/test/java/org/apache/tajo/client/TestTajoDump.java e0d745e > tajo-core/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlan.java > 2f1e0f9 > > tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java > 87262e8 > tajo-core/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java > c2db595 > tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java > 2d289ba > tajo-core/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java > 8453488 > tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java > f5f98a5 > tajo-core/src/test/java/org/apache/tajo/jdbc/TestResultSet.java 4477fa5 > tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java f922d87 > > tajo-core/src/test/java/org/apache/tajo/master/TestExecutionBlockCursor.java > f4fa74a > tajo-core/src/test/java/org/apache/tajo/master/TestGlobalPlanner.java > 0ce7746 > tajo-core/src/test/java/org/apache/tajo/scheduler/TestFifoScheduler.java > 76f22d0 > tajo-core/src/test/java/org/apache/tajo/storage/TestRowFile.java f2784e5 > > tajo-core/src/test/resources/dataset/TestJoinBroadcast/customer_large/customer.tbl > cdccf00 > > tajo-core/src/test/resources/dataset/TestJoinBroadcast/lineitem_large/lineitem.tbl > e637c73 > tajo-core/src/test/resources/dataset/tpch/customer.tbl PRE-CREATION > tajo-core/src/test/resources/dataset/tpch/customer_large.tbl PRE-CREATION > tajo-core/src/test/resources/dataset/tpch/lineitem.tbl PRE-CREATION > tajo-core/src/test/resources/dataset/tpch/lineitem_large.tbl PRE-CREATION > tajo-core/src/test/resources/dataset/tpch/nation.tbl PRE-CREATION > tajo-core/src/test/resources/dataset/tpch/orders.tbl PRE-CREATION > tajo-core/src/test/resources/dataset/tpch/part.tbl PRE-CREATION > tajo-core/src/test/resources/dataset/tpch/partsupp.tbl PRE-CREATION > tajo-core/src/test/resources/dataset/tpch/region.tbl PRE-CREATION > tajo-core/src/test/resources/dataset/tpch/supplier.tbl PRE-CREATION > > tajo-core/src/test/resources/queries/TestJoinBroadcast/create_customer_large_ddl.sql > e5be236 > > tajo-core/src/test/resources/queries/TestJoinBroadcast/create_lineitem_large_ddl.sql > 366f22b > tajo-core/src/test/resources/queries/tpch/customer.sql PRE-CREATION > tajo-core/src/test/resources/queries/tpch/customer_large.sql PRE-CREATION > tajo-core/src/test/resources/queries/tpch/empty_orders.sql PRE-CREATION > tajo-core/src/test/resources/queries/tpch/lineitem.sql PRE-CREATION > tajo-core/src/test/resources/queries/tpch/lineitem_large.sql PRE-CREATION > tajo-core/src/test/resources/queries/tpch/nation.sql PRE-CREATION > tajo-core/src/test/resources/queries/tpch/orders.sql PRE-CREATION > tajo-core/src/test/resources/queries/tpch/part.sql PRE-CREATION > tajo-core/src/test/resources/queries/tpch/partsupp.sql PRE-CREATION > tajo-core/src/test/resources/queries/tpch/region.sql PRE-CREATION > tajo-core/src/test/resources/queries/tpch/supplier.sql PRE-CREATION > > Diff: https://reviews.apache.org/r/21719/diff/ > > > Testing > ------- > > mvn clean install > > > Thanks, > > Jung JaeHwa > >
