[
https://issues.apache.org/jira/browse/TAJO-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027459#comment-14027459
]
ASF GitHub Bot commented on TAJO-836:
-------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/15#discussion_r13635178
--- Diff:
tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateIndex.java ---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.tajo.algebra;
+
+import com.google.common.base.Objects;
+import com.google.gson.annotations.Expose;
+import com.google.gson.annotations.SerializedName;
+import org.apache.tajo.algebra.Sort.SortSpec;
+import org.apache.tajo.util.TUtil;
+
+import java.util.Map;
+
+public class CreateIndex extends UnaryOperator {
+ @Expose @SerializedName("IsUnique")
+ private boolean unique = false;
+ @Expose @SerializedName("IndexName")
+ private String indexName;
+ @Expose @SerializedName("SortSpecs")
+ private SortSpec[] sortSpecs;
+ @Expose @SerializedName("IndexProperties")
+ private Map<String, String> params;
--- End diff --
At first, I worried about the duplicated serialized name of different
operators. As you know, gson does not allow the same serialized name of
different objects.
However, only some DDL operators such as CreateDatabase, CreateTable,
Insert, and CreateIndex have the 'params' value, and these operators are never
connected in a query plan. So, it will be free from the gson restriction for
the same name.
I'll change it. Thanks!
> create index support
> --------------------
>
> Key: TAJO-836
> URL: https://issues.apache.org/jira/browse/TAJO-836
> Project: Tajo
> Issue Type: Sub-task
> Components: operator/expression, physical operator, planner/optimizer
> Reporter: Jihoon Son
> Assignee: Jihoon Son
> Priority: Minor
> Fix For: 0.9.0
>
> Attachments: TAJO-836.patch, TAJO-836_2.patch, TAJO-836_3.patch
>
>
> The synopsis is as follows.
> {noformat}
> CREATE [ UNIQUE ] INDEX [ name ] ON table [ USING method ]
> ( { column | ( expression ) } [ ASC | DESC ] [ NULLS { FIRST | LAST } ]
> [, ...] )
> [ WHERE predicate ]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)