[ 
https://issues.apache.org/jira/browse/TAJO-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034904#comment-14034904
 ] 

ASF GitHub Bot commented on TAJO-774:
-------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/13#discussion_r13901751
  
    --- Diff: 
tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
 ---
    @@ -1021,4 +1046,53 @@ public final void testGroupByEnforcer() throws 
IOException, PlanningException {
     
         assertTrue(exec instanceof SortAggregateExec);
       }
    +
    +  String [] WINDOW = {
    +    "select deptName, class, sum(score) OVER() from score",
    +    "select deptName, score, sum(score) OVER(PARTITION BY deptName) from 
score",
    +    "select deptName, class, score, sum(score) OVER(PARTITION BY deptName, 
class) from score",
    +    "select deptName, class, sum(score), max(score), min(score) from score 
group by deptName, class",
    +  };
    +
    +  @Test
    +  public final void testWindowAggPlan() throws IOException, 
PlanningException {
    +    FileFragment[] frags = StorageManager.splitNG(conf, "default.score", 
score.getMeta(), score.getPath(),
    +        Integer.MAX_VALUE);
    +    Path workDir = 
CommonTestingUtil.getTestDir("target/test-data/testSortGroupByPlan");
    +    TaskAttemptContext ctx = new TaskAttemptContext(conf, new 
QueryContext(),
    +        LocalTajoTestingUtility.newQueryUnitAttemptId(masterPlan),
    +        new FileFragment[]{frags[0]}, workDir);
    +    ctx.setEnforcer(new Enforcer());
    +    Expr context = analyzer.parse(WINDOW[1]);
    +    LogicalPlan plan = planner.createPlan(session, context);
    +    System.out.println(plan);
    --- End diff --
    
    Please remove debug code and commented out code.


> Implement logical plan part and physical executor for window function.
> ----------------------------------------------------------------------
>
>                 Key: TAJO-774
>                 URL: https://issues.apache.org/jira/browse/TAJO-774
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.9.0
>
>
> See the title. The main objective of this issue is to implement the logical 
> planning part for window function support.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to