Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/22#issuecomment-46927666
+1
Although the unit test seems to be failed, the failure is caused by the
long log message. Travis causes failure if the log size > 4MB.
I verified 'mvn clean install'. The patch fixes outer join condition bugs
and includes enough unit tests to verify the bug fix.
In addition, I revised some trivial things as follows:
* Remove unnecessary plan log in GlobalEngine.java
* Remove commented out lines in TajoTestingCluster and
ProjectionPushDownRule
* Rename EvalTreeUtil::findOuterJoinConditionEvals to
EvalTreeUtil::findOuterJoinSensitiveEvals because they are subexpressions of
join condition.
I'll commit it shortly. Thank you for your great contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
