[
https://issues.apache.org/jira/browse/TAJO-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041641#comment-14041641
]
ASF GitHub Bot commented on TAJO-850:
-------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/22#issuecomment-46927666
+1
Although the unit test seems to be failed, the failure is caused by the
long log message. Travis causes failure if the log size > 4MB.
I verified 'mvn clean install'. The patch fixes outer join condition bugs
and includes enough unit tests to verify the bug fix.
In addition, I revised some trivial things as follows:
* Remove unnecessary plan log in GlobalEngine.java
* Remove commented out lines in TajoTestingCluster and
ProjectionPushDownRule
* Rename EvalTreeUtil::findOuterJoinConditionEvals to
EvalTreeUtil::findOuterJoinSensitiveEvals because they are subexpressions of
join condition.
I'll commit it shortly. Thank you for your great contribution!
> OUTER JOIN does not properly handle a NULL.
> -------------------------------------------
>
> Key: TAJO-850
> URL: https://issues.apache.org/jira/browse/TAJO-850
> Project: Tajo
> Issue Type: Bug
> Reporter: Hyoungjun Kim
> Assignee: Hyoungjun Kim
> Priority: Minor
>
> See the title. In the case of the following query NULL value is evaluated at
> the SCAN time.
> {code:sql}
> select
> c_custkey,
> coalesce(orders.o_totalprice, 999.0)
> from
> customer left outer join orders on c_name = o_orderstatus
> {code}
> {code:sql}
> select
> c_custkey,
> from
> customer left outer join orders on c_name = o_orderstatus
> where o_orderdate is null
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
