[
https://issues.apache.org/jira/browse/TAJO-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041782#comment-14041782
]
ASF GitHub Bot commented on TAJO-853:
-------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/28#issuecomment-46937502
I did the follows:
* I've rebased the patch against the latest source code.
* I've fixed unit test failures by adding some workaround code as follows:
```
@AfterClass
public static void tearDown() {
testingCluster.setAllTajoDaemonConfValue(
ConfVars.EXECUTOR_INNER_JOIN_INMEMORY_HASH_THRESHOLD.varname,
String.valueOf(ConfVars.EXECUTOR_INNER_JOIN_INMEMORY_HASH_THRESHOLD.defaultLongVal));
testingCluster.setAllTajoDaemonConfValue(ConfVars.EXECUTOR_OUTER_JOIN_INMEMORY_HASH_THRESHOLD.varname,
String.valueOf(ConfVars.EXECUTOR_OUTER_JOIN_INMEMORY_HASH_THRESHOLD.defaultLongVal));
testingCluster.setAllTajoDaemonConfValue(ConfVars.EXECUTOR_GROUPBY_INMEMORY_HASH_THRESHOLD.varname,
String.valueOf(ConfVars.EXECUTOR_GROUPBY_INMEMORY_HASH_THRESHOLD.defaultLongVal));
}
```
After than, the patch works well. the patch nice to me. Here is my +1.
I'll commit it soon.
Thanks!
> Refactoring FilterPushDown for OUTER JOIN
> -----------------------------------------
>
> Key: TAJO-853
> URL: https://issues.apache.org/jira/browse/TAJO-853
> Project: Tajo
> Issue Type: Improvement
> Reporter: Hyoungjun Kim
> Assignee: Hyoungjun Kim
> Priority: Minor
>
> Currently Tajo doesn't support a filter OUTER JOIN's ON clause.
> or has some bugs. There is some rules for this in the following urls.
> -
> http://www.ibm.com/developerworks/data/library/techarticle/purcell/0112purcell.html
> - https://cwiki.apache.org/confluence/display/Hive/OuterJoinBehavior
> Briefly summarized as follows.
> - Join Predicate on Preserved Row Table: Used for join condition(not filter)
> - Join Predicate on Null Supplying Table: Can push down to the table scan
> - Where Predicate on Preserved Row Table: Can push down to the table scan
> - Where Predicate on Null Supplying Table: Used for filter with join result
> data. This filter condition is attached to SELECTION Node.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
