[ 
https://issues.apache.org/jira/browse/TAJO-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053384#comment-14053384
 ] 

Hyunsik Choi commented on TAJO-912:
-----------------------------------

Hi Mai Hai Thanh,

Your patch looks good to me. Originally, your direction is right. BTW, we 
already have VersionInfo in tajo-common module utility class to allow Tajo to 
get version, source revision, and build information. BTW, we haven't used it so 
far. In addition, if you use HttpURLConnection.openConnection in HelpCommand, 
HelpCommand will not work in private network environments in which Hadoop 
cluster usually are running.

Could you change your patch to use VersionInfo class? 

Thanks,
Hyunsik

> Tsql prints wrong version.
> --------------------------
>
>                 Key: TAJO-912
>                 URL: https://issues.apache.org/jira/browse/TAJO-912
>             Project: Tajo
>          Issue Type: Bug
>          Components: cli
>            Reporter: Jaehwa Jung
>            Assignee: Mai Hai Thanh
>            Priority: Trivial
>              Labels: newbie
>         Attachments: TAJO-912.Mai.140707.0.patch.txt
>
>
> I found that tsql prints wrong version with tajo-0.9.0-SNAPSHOT as follows:
> {code:xml}
> default> \?
> General
>   \copyright  show Apache License 2.0
>   \version    show Tajo version
>   \?          show help
>   \q          quit tsql
> Informational
>   \l           list databases
>   \c           show current database
>   \c [DBNAME]  connect to new database
>   \d           list tables
>   \d [TBNAME]  describe table
>   \df          list functions
>   \df NAME     describe function
> Tool
>   \!           execute a linux shell command
>   \dfs         execute a dfs command
>   \admin       execute tajo admin command
> Variables
>   \set [[NAME] [VALUE]  set session variable or list session variables
>   \unset NAME           unset session variable
> Documentations
>   tsql guide        http://tajo.apache.org/docs/0.8.0/cli.html
>   Query language    http://tajo.apache.org/docs/0.8.0/sql_language.html
>   Functions         http://tajo.apache.org/docs/0.8.0/functions.html
>   Backup & restore  http://tajo.apache.org/docs/0.8.0/backup_and_restore.html
>   Configuration     http://tajo.apache.org/docs/0.8.0/configuration.html
> default> \version
> 0.8.0-SNAPSHOT
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to