----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22374/#review47760 -----------------------------------------------------------
Ship it! +1 The patch looks good to me. Could you more improve the description about the scattered hash shuffle before committing? - Hyunsik Choi On July 15, 2014, 2:27 a.m., Jung JaeHwa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22374/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 2:27 a.m.) > > > Review request for Tajo. > > > Bugs: TAJO-673 > https://issues.apache.org/jira/browse/TAJO-673 > > > Repository: tajo > > > Description > ------- > > When inserting into partitioned table, if the number of partitions is smaller > than cluster concurrency capacity, a query execution is too slow. > > > Diffs > ----- > > tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java dd5327d > > tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java > cf02ecd > > tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java > 4e27574 > > tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashShuffleFileWriteExec.java > 678b745 > tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java > 6cada07 > > tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java > 361f88f > > tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java > ce2194e > tajo-core/src/main/java/org/apache/tajo/worker/Task.java ee3c40d > tajo-core/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java > e073652 > tajo-core/src/main/proto/TajoWorkerProtocol.proto 3bf6e13 > > tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java > c34c3f4 > > tajo-yarn-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java > b8fda29 > > tajo-yarn-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java > 373642b > > Diff: https://reviews.apache.org/r/22374/diff/ > > > Testing > ------- > > mvn clean install > > > Thanks, > > Jung JaeHwa > >
