[
https://issues.apache.org/jira/browse/TAJO-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061699#comment-14061699
]
ASF GitHub Bot commented on TAJO-933:
-------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/75#issuecomment-48992605
In my opinion, we don't need additional unit tests because this patch just
forks some of parquet classes which were included in parquet library.
> Fork some classes of Parquet as builtin third-party classes
> -----------------------------------------------------------
>
> Key: TAJO-933
> URL: https://issues.apache.org/jira/browse/TAJO-933
> Project: Tajo
> Issue Type: Improvement
> Components: storage
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Priority: Minor
> Labels: newbie, parquet
> Fix For: 0.9.0
>
>
> Parquet has strict modifier and encapsulation design. This is well designed,
> but it does not allow us to add desired features to Parquet. For example, it
> is hard to get the written file size and how many memory buffer is filled.
> I propose forking some classes of Parquet file format as embed third-party
> classes. After then, we can revise them tailored for Tajo.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
