[
https://issues.apache.org/jira/browse/TAJO-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075845#comment-14075845
]
ASF GitHub Bot commented on TAJO-974:
-------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/93#issuecomment-50294216
+1
The patch looks good to me.
> Eliminate unexpected case condition in SubQuery
> -----------------------------------------------
>
> Key: TAJO-974
> URL: https://issues.apache.org/jira/browse/TAJO-974
> Project: Tajo
> Issue Type: Bug
> Components: distributed query plan
> Reporter: Hyunsik Choi
> Assignee: Hyoungjun Kim
> Fix For: 0.9.0
>
>
> Please take a loot at the below code. In
> SubQuery::calculateShuffleOutputNum() method, if-condition will be passed
> through the unexpected case if the plan is neither group by and join. In
> current implementation, distinct group-by operator can cause this case.
> Actually, the below code is messy. We need to directly handle distinct group
> by and clean up the below code.
> {code:title="SubQuery::calculateShuffleOutputNum()"}
> } else {
> LOG.info("============>>>>> Unexpected Case! <<<<<================");
> long volume = getInputVolume(subQuery.masterPlan, subQuery.context,
> subQuery.block);
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
