[
https://issues.apache.org/jira/browse/TAJO-957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077307#comment-14077307
]
Hyunsik Choi commented on TAJO-957:
-----------------------------------
Hi Mai,
Thank you for your contribution. Your fix looks nice. I have one suggestion.
Could you move your unit test to TestMathFunctions with the proper name?
TestMathFunctions would be a better place to include the unit test. After than,
I'll finish the review.
In addition, in my point of view, there is one more hidden problem. That is a
bug (or incorrect implemented) of function finding mechanism which finds the
compatible function, even though they are not exactly matched. It can be
defined as both functions are compatible if both function arguments can be
casted without precision loss. It was implemented in TAJO-215. For example, INT
can be casted to FLOAT8 (double) or LONG without precision loss. So,
CatalogServer should have found ROUND(FLOAT8) even though ROUND(INT4) function
is absent.
If you want to solve this problem in this issue, you can do it. Otherwise, I'll
create another jira issue.
> ROUND should be support INT parameter.
> --------------------------------------
>
> Key: TAJO-957
> URL: https://issues.apache.org/jira/browse/TAJO-957
> Project: Tajo
> Issue Type: Improvement
> Reporter: Hyoungjun Kim
> Assignee: Mai Hai Thanh
> Priority: Trivial
> Attachments: TAJO-957.patch.txt
>
>
> Currently Tajo returns error the following query.
> {noformat}
> default> select round(10);
> ERROR: function round(int4) does not exist
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
