[ 
https://issues.apache.org/jira/browse/TAJO-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084225#comment-14084225
 ] 

ASF GitHub Bot commented on TAJO-987:
-------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/101#discussion_r15738637
  
    --- Diff: 
tajo-core/src/test/java/org/apache/tajo/master/TestRepartitioner.java ---
    @@ -18,15 +18,21 @@
     
     package org.apache.tajo.master;
     
    +import com.google.common.collect.Maps;
     import org.apache.tajo.ExecutionBlockId;
     import org.apache.tajo.QueryId;
     import org.apache.tajo.TestTajoIds;
     import org.apache.tajo.ipc.TajoWorkerProtocol;
    +import org.apache.tajo.master.querymaster.QueryMaster;
     import org.apache.tajo.master.querymaster.QueryUnit;
    +import org.apache.tajo.master.querymaster.Repartitioner;
    +import org.apache.tajo.master.querymaster.SubQuery;
    +import org.apache.tajo.util.Pair;
     import org.apache.tajo.util.TUtil;
     import org.apache.tajo.worker.FetchImpl;
     import org.jboss.netty.handler.codec.http.QueryStringDecoder;
     import org.junit.Test;
    +import org.mockito.Mockito;
    --- End diff --
    
    There are some unused imports.
    Please remove them.


> Hash shuffle should be balanced according to intermediate volumes
> -----------------------------------------------------------------
>
>                 Key: TAJO-987
>                 URL: https://issues.apache.org/jira/browse/TAJO-987
>             Project: Tajo
>          Issue Type: Bug
>          Components: data shuffle
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.9.0
>
>
> It is not hard to see skewed data set in practice. Currently, hash shuffled 
> intermediate are performed by distributing partition keys without considering 
> their partition volumes. As a result, with skewed intermediate data, a few of 
> nodes are likely to take much longer time than most of all nodes. It can 
> cause performance degradation. We need some solution to mitigate this problem.
> This patch assigns the intermediate data by balancing their volumes. The 
> approach is a kind of greedy algorithm. In many cases, the shuffle num can be 
> over tens of thousands. I also considered the computation complexity. Its 
> complexity is O \(n\). It will show reasonable performance and balanced 
> results.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to