[
https://issues.apache.org/jira/browse/TAJO-947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hyunsik Choi updated TAJO-947:
------------------------------
Attachment: TAJO-947_2.patch
+1
Your patch looks nice to me. I've changed some trivial things as follows:
* ReIndented some methods of StringUtils.
* Moved the unit tests in TestCaseByCases to TestTablePartitions.
* Added some result close code in the unit tests.
If you agree with my change, I'll commit it shortly.
Thank you for your contribution!
> ColPartitionStoreExec can cause URISyntaxException due to special characters
> ----------------------------------------------------------------------------
>
> Key: TAJO-947
> URL: https://issues.apache.org/jira/browse/TAJO-947
> Project: Tajo
> Issue Type: Bug
> Components: physical operator
> Reporter: Hyunsik Choi
> Assignee: Mai Hai Thanh
> Fix For: 0.9.0
>
> Attachments: TAJO-947.Mai.140728.patch.txt,
> TAJO-947.Mai.140730.patch.txt, TAJO-947_2.patch
>
>
> When partition keys includes some special characters which cannot be
> represented in URI, ColPartitionStoreExec::getData can cause
> URISyntaxException. Please see the following stack trace:
> {noformat}
> Progress: 62%, response time: 106.344 sec
> Progress: 62%, response time: 107.345 sec
> Progress: 62%, response time: 108.347 sec
> ERROR: java.net.URISyntaxException: Relative path in absolute URI:
> l_returnflag=yly:%20furiously%20ev/part-02-000002-000
> java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative
> path in absolute URI: l_returnflag=yly:%20furiously%20ev/part-02-000002-000
> at org.apache.hadoop.fs.Path.initialize(Path.java:206)
> at org.apache.hadoop.fs.Path.<init>(Path.java:172)
> at org.apache.hadoop.fs.Path.<init>(Path.java:94)
> at org.apache.tajo.storage.StorageUtil.concatPath(StorageUtil.java:104)
> at
> org.apache.tajo.engine.planner.physical.ColPartitionStoreExec.getDataFile(ColPartitionStoreExec.java:112)
> at
> org.apache.tajo.engine.planner.physical.SortBasedColPartitionStoreExec.getAppenderForNewPartition(SortBasedColPartitionStoreExec.java:86)
> at
> org.apache.tajo.engine.planner.physical.SortBasedColPartitionStoreExec.next(SortBasedColPartitionStoreExec.java:156)
> at org.apache.tajo.worker.Task.run(Task.java:425)
> at org.apache.tajo.worker.TaskRunner$1.run(TaskRunner.java:406)
> at java.lang.Thread.run(Thread.java:744)
> Caused by: java.net.URISyntaxException: Relative path in absolute URI:
> l_returnflag=yly:%20furiously%20ev/part-02-000002-000
> at java.net.URI.checkPath(URI.java:1804)
> at java.net.URI.<init>(URI.java:752)
> at org.apache.hadoop.fs.Path.initialize(Path.java:203)
> ... 9 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
