[
https://issues.apache.org/jira/browse/TAJO-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101797#comment-14101797
]
ASF GitHub Bot commented on TAJO-1011:
--------------------------------------
GitHub user blrunner opened a pull request:
https://github.com/apache/tajo/pull/122
TAJO-1011: EvalTreeUtil::isJoinQual need to handle other join conditions.
TAJO-1011: EvalTreeUtil::isJoinQual need to handle other join conditions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blrunner/tajo TAJO-1011
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #122
----
commit 7c98709f0fcb06dfb675acae3d6489a6126f55b5
Author: jinossy <[email protected]>
Date: 2014-08-06T08:43:35Z
TAJO-995: HiveMetaStoreClient wrapper should retry the connection
commit 415d0867ae4a4543f47360294bead1fc7f41e292
Author: Jaehwa Jung <[email protected]>
Date: 2014-08-10T06:07:24Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo
commit 7a7b4fd26f61df89cacdb4fc41faf9c2abe456b2
Author: Jaehwa Jung <[email protected]>
Date: 2014-08-11T02:28:48Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo
commit 45f5ed3adba931f4706f26dda1d3c03240ee11d3
Author: Jaehwa Jung <[email protected]>
Date: 2014-08-11T05:40:25Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo
commit aa01e83859ef553ac4eb90c1678e3bc6be20c6c9
Author: Jaehwa Jung <[email protected]>
Date: 2014-08-18T09:56:24Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo
commit 95f08323e5a46d550535f7b2f8f9deb5801a6338
Author: Jaehwa Jung <[email protected]>
Date: 2014-08-19T03:30:14Z
Merge branch 'master' of https://github.com/blrunner/tajo into HEAD
commit 82892eeea6000133db134b75556411da30f9f2ef
Author: Jaehwa Jung <[email protected]>
Date: 2014-08-19T03:32:50Z
TAJO-1011: EvalTreeUtil::isJoinQual need to handle other join conditions.
----
> EvalTreeUtil::isJoinQual need to handle other join conditions.
> --------------------------------------------------------------
>
> Key: TAJO-1011
> URL: https://issues.apache.org/jira/browse/TAJO-1011
> Project: Tajo
> Issue Type: Bug
> Components: planner/optimizer
> Reporter: Jaehwa Jung
> Assignee: Jaehwa Jung
>
> Currently, EvalTreeUtil::isJoinQual doesn't handle as follows:
> {code:title=Constant field|borderStyle=solid}
> select * from lineitem where l_orderkey = 2;
> {code}
> {code:title=Alias field using function|borderStyle=solid}
> select n1.n_nationkey, substr(n1.n_name, 1, 4) name1, substr(n2.n_name,
> 1, 4) name2
> from nation n1 join nation n2 on substr(n1.n_name, 1, 4) = substr(n2.n_name,
> 1, 4)
> order by n1.n_nationkey;
> {code}
> To above cases, current tajo can't pass unit test cases as follows:
> {code:xml}
> Failed tests:
> testBroadcastPartitionTable(org.apache.tajo.engine.query.TestJoinBroadcast):
> Table [customer_broad_parts] creation is failed.
>
> testPartitionMultiplePartitionFilter(org.apache.tajo.engine.query.TestJoinOnPartitionedTables):
> Table [customer_parts] creation is failed.
>
> testFilterPushDownPartitionColumnCaseWhen(org.apache.tajo.engine.query.TestJoinOnPartitionedTables):
> Table [customer_parts] creation is failed.
>
> testRightOuterJoinPredicationCaseByCase3[0](org.apache.tajo.engine.query.TestJoinQuery):
> expected:<[id,name,id,id(..)
>
> testLeftOuterJoinPredicationCaseByCase3[0](org.apache.tajo.engine.query.TestJoinQuery):
> expected:<[id,name,id,id(..)
> testComplexJoinCondition4[0](org.apache.tajo.engine.query.TestJoinQuery):
> Result Verification expected:<...-------(..)
> testComplexJoinCondition5[0](org.apache.tajo.engine.query.TestJoinQuery):
> Result Verification expected:<...-------(..)
> testComplexJoinCondition6[0](org.apache.tajo.engine.query.TestJoinQuery):
> Result Verification expected:<...0,ALGE,ALGE(..)
> testOuterJoinAndCaseWhen1[0](org.apache.tajo.engine.query.TestJoinQuery):
> Table [table1] creation is failed.
>
> testRightOuterJoinPredicationCaseByCase3[1](org.apache.tajo.engine.query.TestJoinQuery):
> expected:<[id,name,id,id(..)
>
> testLeftOuterJoinPredicationCaseByCase3[1](org.apache.tajo.engine.query.TestJoinQuery):
> expected:<[id,name,id,id(..)
> testComplexJoinCondition4[1](org.apache.tajo.engine.query.TestJoinQuery):
> Result Verification expected:<...-------(..)
> testComplexJoinCondition5[1](org.apache.tajo.engine.query.TestJoinQuery):
> Result Verification expected:<...-------(..)
> testComplexJoinCondition6[1](org.apache.tajo.engine.query.TestJoinQuery):
> Result Verification expected:<...0,ALGE,ALGE(..)
> testOuterJoinAndCaseWhen1[1](org.apache.tajo.engine.query.TestJoinQuery):
> Table [table1] creation is failed.
> testComplexJoinCondition4[2](org.apache.tajo.engine.query.TestJoinQuery):
> Result Verification expected:<...-------(..)
> testComplexJoinCondition5[2](org.apache.tajo.engine.query.TestJoinQuery):
> Result Verification expected:<...-------(..)
> testComplexJoinCondition6[2](org.apache.tajo.engine.query.TestJoinQuery):
> Result Verification expected:<...0,ALGE,ALGE(..)
> testOuterJoinAndCaseWhen1[2](org.apache.tajo.engine.query.TestJoinQuery):
> Table [table1] creation is failed.
> testComplexJoinCondition4[3](org.apache.tajo.engine.query.TestJoinQuery):
> Result Verification expected:<...-------(..)
> testComplexJoinCondition5[3](org.apache.tajo.engine.query.TestJoinQuery):
> Result Verification expected:<...-------(..)
> testComplexJoinCondition6[3](org.apache.tajo.engine.query.TestJoinQuery):
> Result Verification expected:<...0,ALGE,ALGE(..)
> testOuterJoinAndCaseWhen1[3](org.apache.tajo.engine.query.TestJoinQuery):
> Table [table1] creation is failed.
> testSortWithDate(org.apache.tajo.engine.query.TestSortQuery): Table
> [table1] creation is failed.
> Tests in error:
> testQ2FourJoins(org.apache.tajo.benchmark.TestTPCH):
> java.util.NoSuchElementException(..)
> testCastFromTable(org.apache.tajo.engine.eval.TestSQLExpression)
> testEqual(org.apache.tajo.engine.planner.physical.TestBSTIndexExec)
>
> testCreateScanWithFilterPlan(org.apache.tajo.engine.planner.physical.TestPhysicalPlanner)
> testProjectionPush(org.apache.tajo.engine.planner.TestLogicalOptimizer)
> testOptimizeWithGroupBy(org.apache.tajo.engine.planner.TestLogicalOptimizer)
>
> testJoinWithMultipleJoinQual2(org.apache.tajo.engine.planner.TestLogicalPlanner)
>
> testJoinWithMultipleJoinQual3(org.apache.tajo.engine.planner.TestLogicalPlanner)
>
> testJoinWithMultipleJoinQual4(org.apache.tajo.engine.planner.TestLogicalPlanner)
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
