[ 
https://issues.apache.org/jira/browse/TAJO-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119662#comment-14119662
 ] 

ASF GitHub Bot commented on TAJO-937:
-------------------------------------

GitHub user mhthanh opened a pull request:

    https://github.com/apache/tajo/pull/131

    TAJO-937: Should use tajo.util.VersionInfo instead of 
TajoConstants.TAJO_VERSION

    Replaced all of the usages of TajoConstants.TAJO_VERSION by 
tajo.util.VersionInfo.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mhthanh/tajo TAJO-937

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #131
    
----
commit bee568420afab67f004ff4f3cbf9d3d53d4e110e
Author: mhthanh <[email protected]>
Date:   2014-09-03T08:42:22Z

    TAJO-937: Should use tajo.util.VersionInfo instead of
    TajoConstants.TAJO_VERSION

commit 46a4c6609b50cbb07e4fae3e58706a4062bb0e44
Author: mhthanh <[email protected]>
Date:   2014-09-03T08:46:18Z

    TAJO-937: Should use tajo.util.VersionInfo instead of
    TajoConstants.TAJO_VERSION

commit b7dcb575e8b0b0cb7a0d25ecc1d0dde4063a45c8
Author: mhthanh <[email protected]>
Date:   2014-09-03T08:46:18Z

    TAJO-937: Should use tajo.util.VersionInfo instead of
    TajoConstants.TAJO_VERSION

commit 5bd4251895b8822b216ee32a2d671b2433a17fb6
Author: mhthanh <[email protected]>
Date:   2014-09-03T08:49:16Z

    Merge branch 'TAJO-937' of https://github.com/mhthanh/tajo.git into TAJO-937

----


> Should use tajo.util.VersionInfo instead of TajoConstants.TAJO_VERSION
> ----------------------------------------------------------------------
>
>                 Key: TAJO-937
>                 URL: https://issues.apache.org/jira/browse/TAJO-937
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Hyunsik Choi
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 0.9.0
>
>
> So far, we have used TajoConstants.TAJO_VERSION throughout the entire 
> project. But, we adopted tajo.util.VersionInfo. It automatically generates 
> version-info.properties in tajo-common-${version}.jar. So, it always provides 
> exact version. We should replace all of the usages of 
> TajoConstants.TAJO_VERSION by tajo.util.VersionInfo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to