Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/136#issuecomment-55274187
It's great work. The patch looks great to me. In addition, the algorithm is
very well defined and code is very clean. It's readability is very nice.
But, there is lack of documentation to explain overall three steps of
distinct aggregation. Only someone who already knows the algorithm can
understand the source code. DistinctGroupbyBuilder may be good place to have
the description.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
