[
https://issues.apache.org/jira/browse/TAJO-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133200#comment-14133200
]
ASF GitHub Bot commented on TAJO-1024:
--------------------------------------
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/139
TAJO-1024: RpcConnectionPool::getConnection can cause NPE at initialization
It's concurrency bug. So, it is hard to reproduce the case. So, I omitted
the unit tests. But, it definitely fixes the bug. After I apply it, I couldn't
see the bug again. @jinossy helped this work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1024
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/139.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #139
----
commit faba3e372e8f9397f73a627db9c65f9467ae27a8
Author: Hyunsik Choi <[email protected]>
Date: 2014-09-14T13:06:08Z
TAJO-1024: RpcConnectionPool::getConnection can cause NPE at initialization.
----
> RpcConnectionPool::getConnection can cause NPE at initialization
> ----------------------------------------------------------------
>
> Key: TAJO-1024
> URL: https://issues.apache.org/jira/browse/TAJO-1024
> Project: Tajo
> Issue Type: Bug
> Components: query master, rpc
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Priority: Minor
>
> I can see the following NPE exception when I submit the first query after
> cluster startup. Although the NPE does not abort a running query, it should
> be fixed.
> {noformat}
> 2014-09-02 09:41:12,925 INFO org.apache.tajo.worker.TajoResourceAllocator:
> Start TajoWorkerAllocationThread
> 2014-09-02 09:41:12,970 INFO org.apache.tajo.worker.TajoResourceAllocator:
> Stop TajoWorkerAllocationThread
> 2014-09-02 09:41:12,970 INFO org.apache.tajo.master.querymaster.SubQuery:
> SubQuery (eb_1409618466499_0001_000001) has 3 containers!
> 2014-09-02 09:41:13,010 ERROR org.apache.tajo.master.ContainerProxy:
> java.lang.NullPointerException
> at
> org.apache.tajo.rpc.RpcConnectionPool.getConnection(RpcConnectionPool.java:87)
> at
> org.apache.tajo.master.TajoContainerProxy.assignExecutionBlock(TajoContainerProxy.java:99)
> at
> org.apache.tajo.master.TajoContainerProxy.launch(TajoContainerProxy.java:70)
> at
> org.apache.tajo.worker.TajoResourceAllocator$LaunchRunner.run(TajoResourceAllocator.java:170)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:744)
> 2014-09-02 09:41:13,010 ERROR org.apache.tajo.master.ContainerProxy:
> java.lang.NullPointerException
> at
> org.apache.tajo.rpc.RpcConnectionPool.getConnection(RpcConnectionPool.java:87)
> at
> org.apache.tajo.master.TajoContainerProxy.assignExecutionBlock(TajoContainerProxy.java:99)
> at
> org.apache.tajo.master.TajoContainerProxy.launch(TajoContainerProxy.java:70)
> at
> org.apache.tajo.worker.TajoResourceAllocator$LaunchRunner.run(TajoResourceAllocator.java:170)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:744)
> 2014-09-02 09:41:13,031 INFO org.apache.tajo.worker.TaskRunner: Tajo Root
> Dir: hdfs://localhost:8020/tajo
> 2014-09-02 09:41:13,031 INFO org.apache.tajo.worker.TaskRunner: Worker Local
> Dir: /tmp/tajo-hyunsik/tmpdir
> 2014-09-02 09:41:13,047 INFO org.apache.tajo.worker.TaskRunner: QueryMaster
> Address:/172.20.10.7:28093
> 2014-09-02 09:41:13,048 INFO org.apache.tajo.worker.TaskRunnerManager: Start
> TaskRunner:eb_1409618466499_0001_000001,container_1409618466499_0001_01_000003
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
