[ 
https://issues.apache.org/jira/browse/TAJO-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140639#comment-14140639
 ] 

ASF GitHub Bot commented on TAJO-1030:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/145#discussion_r17787285
  
    --- Diff: 
tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSetMetaData.java ---
    @@ -112,7 +113,7 @@ public int getScale(int column) throws SQLException {
     
       @Override
       public String getSchemaName(int column) throws SQLException {
    -    throw new SQLFeatureNotSupportedException("getSchemaName not 
supported");
    +    return "";
    --- End diff --
    
    How about using 'public' as a default schema name? It's because PostgreSQL 
uses 'public' as a default schema and we would also use 'public' as a default 
schema if we should support schema.
    
    
    http://www.postgresql.org/docs/8.1/static/ddl-schemas.html


> Not supported JDBC APIs should return empty results instead of Exception
> ------------------------------------------------------------------------
>
>                 Key: TAJO-1030
>                 URL: https://issues.apache.org/jira/browse/TAJO-1030
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Hyunsik Choi
>            Assignee: Hyoungjun Kim
>            Priority: Minor
>
> Currently, some unsupported JDBC APIs throw Exception. They do not allow 
> exiting JDBC like BI solutions to connect Tajo. So, we should change them to 
> result in empty results with correct schemas.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to