[ 
https://issues.apache.org/jira/browse/TAJO-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145692#comment-14145692
 ] 

Mai Hai Thanh commented on TAJO-983:
------------------------------------

Thank Hyunsik,
I agree with your additional changes, which clearly make the patch better. 
Please go on! It's my pleasure to make contributions to Tajo.

Beside, I have also read your notice on the review board about the coding 
standard in which I should use 2 spaces instead of tab. I am sorry about that. 
To use spaces instead of tabs, actually, I have already checked the check-box 
"Insert spaces for tabs" (default is un-checked, in menu Window -> Preferences 
-> General -> Editors -> Text Editors), and then use Shift+Ctrl+F to format the 
code automatically. So, I thought that the code had already followed the coding 
standard and I don't know what I should do further. When you have time, please 
make a short instruction in the document about this. I am sure that it will be 
useful for new comers, especially the ones who do not have much experience with 
Eclipse like me!

> Worker should directly read Intermediate data stored in localhost rather than 
> fetching
> --------------------------------------------------------------------------------------
>
>                 Key: TAJO-983
>                 URL: https://issues.apache.org/jira/browse/TAJO-983
>             Project: Tajo
>          Issue Type: Bug
>          Components: data shuffle
>            Reporter: Hyunsik Choi
>            Assignee: Mai Hai Thanh
>         Attachments: TAJO-983.140820.0.patch.txt, TAJO-983.140822.patch.txt, 
> TAJO-983.140825.1.patch.txt, TAJO-983.140902.patch, TAJO-983.140904.patch, 
> TAJO-983.140916.patch, TAJO-983.140918.patch, TAJO-983.140922.patch, 
> TAJO-983.140923.patch, TAJO-983.140924-Hyunsik.patch
>
>
> Currently, worker always fetches all intermediate via Fetcher and than store 
> them in local file system even though some intermediate data already are  
> stored in local file system. It is inefficient and causes unnecessary I/O and 
> extra storage occupation. We should improve it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to