[
https://issues.apache.org/jira/browse/TAJO-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145780#comment-14145780
]
ASF GitHub Bot commented on TAJO-1061:
--------------------------------------
Github user mhthanh commented on a diff in the pull request:
https://github.com/apache/tajo/pull/157#discussion_r17951049
--- Diff: tajo-docs/src/main/sphinx/getting_started/building.rst ---
@@ -11,9 +11,14 @@ You can compile source code and get a binary archive as
follows:
.. code-block:: bash
$ cd tajo-x.y.z
- $ mvn clean install -DskipTests -Pdist -Dtar
+ $ mvn clean install -DskipTests -Pdist -Dtar -Dhadoop.version=xyz
$ ls tajo-dist/target/tajo-x.y.z-SNAPSHOT.tar.gz
+.. note::
+
+ If you doesn't specify the hadoop version, tajo cluster may not run
correctly. Thus, You must specify your hadoop version with maven build command
as follows.
--- End diff --
I think there are some typos:
+ "If you doesn't" -> "If you don't"
+ "Thus, You must" -> "Thus, you must"
Beside, version "2.5.1" is not mandatory. It is just an example. Specifying
a hadoop version is also not mandatory. Tajo can also work correctly at least
in my system even though I do not specify a hadoop version. So, instead of
saying "Thus, you must specify your hadoop version with maven build command as
follows", I would like to suggest to write "Thus, we highly recommend that you
specify your hadoop version with maven build command, for example, as follows"
> Update build documentation
> --------------------------
>
> Key: TAJO-1061
> URL: https://issues.apache.org/jira/browse/TAJO-1061
> Project: Tajo
> Issue Type: Sub-task
> Components: documentation
> Reporter: Jaehwa Jung
> Assignee: Jaehwa Jung
> Fix For: 0.9.0
>
>
> Current tajo version missed hadoop version.
> http://tajo.apache.org/docs/current/getting_started/building.html
> So, lots of tajo beginners easily failed to run their tajo cluster. Thus, we
> need to add the hadoop version to the documentation. In addition, we need to
> add more useful informations to it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
