[jira] [Commented] (TAJO-1084) Generated classes should access directly UnSafeTuple and RowWriter.

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TAJO-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154454#comment-14154454
 ] 

ASF GitHub Bot commented on TAJO-1084:
--------------------------------------

Github user jinossy commented on the pull request:

    https://github.com/apache/tajo/pull/171#issuecomment-57424955
  
    @hyunsik 
    Could you update the HeapTupleBytesComparator.java with JDK 1.6 ?
    ```
    [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project tajo-storage: Compilation failure: Compilation failure:
    [ERROR] 
/Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[42,47]
 cannot find symbol
    [ERROR] symbol  : variable ARRAY_BYTE_BASE_OFFSET
    [ERROR] location: class sun.misc.Unsafe
    [ERROR] 
/Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[42,24]
 cannot find symbol
    [ERROR] symbol  : method getInt(byte[],<nulltype>)
    [ERROR] location: class sun.misc.Unsafe
    [ERROR] 
/Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[43,47]
 cannot find symbol
    [ERROR] symbol  : variable ARRAY_BYTE_BASE_OFFSET
    [ERROR] location: class sun.misc.Unsafe
    [ERROR] 
/Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[43,24]
 cannot find symbol
    [ERROR] symbol  : method getInt(byte[],<nulltype>)
    [ERROR] location: class sun.misc.Unsafe
    [ERROR] 
/Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[57,46]
 cannot find symbol
    [ERROR] symbol  : variable ARRAY_BYTE_BASE_OFFSET
    [ERROR] location: class sun.misc.Unsafe
    [ERROR] 
/Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[57,22]
 cannot find symbol
    [ERROR] symbol  : method getLong(byte[],<nulltype>)
    [ERROR] location: class sun.misc.Unsafe
    [ERROR] 
/Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[58,46]
 cannot find symbol
    [ERROR] symbol  : variable ARRAY_BYTE_BASE_OFFSET
    [ERROR] location: class sun.misc.Unsafe
    [ERROR] 
/Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[58,22]
 cannot find symbol
    [ERROR] symbol  : method getLong(byte[],<nulltype>)
    [ERROR] location: class sun.misc.Unsafe
    [ERROR] 
/Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[95,49]
 cannot find symbol
    [ERROR] symbol  : variable ARRAY_BYTE_BASE_OFFSET
    [ERROR] location: class sun.misc.Unsafe
    [ERROR] 
/Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[95,25]
 cannot find symbol
    [ERROR] symbol  : method getByte(byte[],<nulltype>)
    [ERROR] location: class sun.misc.Unsafe
    [ERROR] 
/Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[96,40]
 cannot find symbol
    [ERROR] symbol  : variable ARRAY_BYTE_BASE_OFFSET
    [ERROR] location: class sun.misc.Unsafe
    [ERROR] 
/Users/kimjh/asf-patch/incubator-tajo/tajo-storage/src/main/java/org/apache/tajo/tuple/offheap/HeapTupleBytesComparator.java:[96,16]
 cannot find symbol
    [ERROR] symbol  : method getByte(byte[],<nulltype>)
    [ERROR] location: class sun.misc.Unsafe
    ```


> Generated classes should access directly UnSafeTuple and RowWriter.
> -------------------------------------------------------------------
>
>                 Key: TAJO-1084
>                 URL: https://issues.apache.org/jira/browse/TAJO-1084
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: compilation
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: block_iteration
>
>
> This patch improves code generation part to directly access UnSafeTuple and 
> RowWriter without converting Datum.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)