[
https://issues.apache.org/jira/browse/TAJO-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166392#comment-14166392
]
ASF GitHub Bot commented on TAJO-1095:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/181#discussion_r18688459
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java
---
@@ -249,36 +249,45 @@ public Expr visitInsert(Context context, Stack<Expr>
stack, Insert expr) throws
if (child != null && child.getType() == OpType.Projection) {
Projection projection = (Projection) child;
- int projectColumnNum = projection.getNamedExprs().length;
- if (expr.hasTargetColumns()) {
- int targetColumnNum = expr.getTargetColumns().length;
+ boolean includeAsterisk = true;
- if (targetColumnNum > projectColumnNum) {
- context.state.addVerification("INSERT has more target columns
than expressions");
- } else if (targetColumnNum < projectColumnNum) {
- context.state.addVerification("INSERT has more expressions than
target columns");
- }
- } else {
- if (expr.hasTableName()) {
- String qualifiedName = expr.getTableName();
- if
(TajoConstants.EMPTY_STRING.equals(CatalogUtil.extractQualifier(expr.getTableName())))
{
- qualifiedName =
CatalogUtil.buildFQName(context.queryContext.getCurrentDatabase(),
- expr.getTableName());
- }
+ for (NamedExpr namedExpr : projection.getNamedExprs()) {
+ includeAsterisk |= namedExpr.getExpr().getType() !=
OpType.Asterisk;
--- End diff --
It seems that 'includeAsterisk' is always true, because the initial value
is true, and some boolean values are ORed.
> Implement Json file scanner
> ---------------------------
>
> Key: TAJO-1095
> URL: https://issues.apache.org/jira/browse/TAJO-1095
> Project: Tajo
> Issue Type: New Feature
> Components: storage
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.9.1
>
>
> Json file format is very common format in many web service applications. JSON
> file support is very desired feature for users who want to analysis web data.
> We also need to support this feature.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
