Github user mvhlong commented on the pull request:
https://github.com/apache/tajo/pull/200#issuecomment-59156973
Thank @jihoonson,
I added the "@VisibleForTesting" annotation and the explanation for
"lastAnalyzed". I also removed the use of "round()" after "floor()" (it became
redundant after a bug fix). However, I do not use
"yarn.util.SystemClock.getTime()" instead of "System.currentTimeMillis()"
because the source code of SystemClock.getTime() just contains a single call to
System.currentTimeMillis(). The use of former function adds unnecessary package
dependency while System.currentTimeMillis() is also used in many other places
in Tajo source code. "isReady" is intentionally omitted somewhere because it is
not related to the real content of a histogram. Finally, I try not to use
NumericDatum since it's not necessary but increases processing time. As I
understand, a Tajo member is trying to avoid the use of Datum in a Jira issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
