[
https://issues.apache.org/jira/browse/TAJO-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173347#comment-14173347
]
Hyunsik Choi commented on TAJO-233:
-----------------------------------
The patch looks good to me. Thank you for your work. For most features, your
patch works well. But, the patch causes the following error when partitioned
table is handled:
{noformat}
Caused by: com.google.protobuf.InvalidProtocolBufferException: Protocol message
end-group tag did not match expected tag.
at
com.google.protobuf.InvalidProtocolBufferException.invalidEndTag(InvalidProtocolBufferException.java:94)
at
com.google.protobuf.CodedInputStream.checkLastTagWas(CodedInputStream.java:124)
at
com.google.protobuf.AbstractParser.parsePartialFrom(AbstractParser.java:143)
at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:176)
at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:188)
at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:193)
at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:49)
at
org.apache.tajo.catalog.proto.CatalogProtos$SchemaProto.parseFrom(CatalogProtos.java:1806)
at
org.apache.tajo.catalog.store.AbstractDBStore.resultToPartitionMethodProto(AbstractDBStore.java:1952)
at
org.apache.tajo.catalog.store.AbstractDBStore.getTable(AbstractDBStore.java:1295)
{noformat}
TestCatalog.java is very good testing tool for catalog store. Please see the
wiki page at https://cwiki.apache.org/confluence/display/TAJO/Unit+Tests. I've
added an example JVM option for PostgreSQLStore. You can use TestCatalog with
your PostgreSQLStore by using the following JVM option.
{noformat}
-Dtajo.catalog.store.class=org.apache.tajo.catalog.store.PostgreSQLStore
-Dtajo.catalog.connection.id=username
-Dtajo.catalog.connection.password=password
-Dtajo.catalog.uri=jdbc:postgresql://localhost/databasename
{noformat}
> Support PostgreSQL CatalogStore
> -------------------------------
>
> Key: TAJO-233
> URL: https://issues.apache.org/jira/browse/TAJO-233
> Project: Tajo
> Issue Type: New Feature
> Components: catalog
> Reporter: Hyunsik Choi
> Assignee: Jihun Kang
> Labels: newbie
> Fix For: 0.9.1
>
> Attachments: postgresql.diff
>
>
> See the title. PostgreSQL is also an widely used open source DBMS. Like
> TAJO-179, we need to support postgresql catalog store.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
