[
https://issues.apache.org/jira/browse/TAJO-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173480#comment-14173480
]
ASF GitHub Bot commented on TAJO-1112:
--------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/200#issuecomment-59323696
Your patch is a very nice starting point for histogram in Apache Tajo. The
patch looks good to me. Additionally, I leave some comments.
As you mentioned, precision is less important in sampling approaches. In
many cases, using double may be a right solution. But, when it comes to value
range representation, Double still has limitation.
in many cases, Text value can be easily longer than the representation
range of DOUBLE or LONG. I already fixed many bugs of sort bugs caused by long
text value (up to 256 bytes). For ETL workloads, it is usual. Also, can Double
represent an entire Long range? We need to check it. In my opinion, we need to
use four value types: Long, Double, Text, and Byte [].
Also, I'll start other discussions in TAJO-1091
(https://issues.apache.org/jira/browse/TAJO-1091).
> Implement histogram interface and a candidate histogram
> -------------------------------------------------------
>
> Key: TAJO-1112
> URL: https://issues.apache.org/jira/browse/TAJO-1112
> Project: Tajo
> Issue Type: Sub-task
> Reporter: Long Mvh
> Assignee: Long Mvh
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
