[ 
https://issues.apache.org/jira/browse/TAJO-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176230#comment-14176230
 ] 

ASF GitHub Bot commented on TAJO-1124:
--------------------------------------

GitHub user hyunsik opened a pull request:

    https://github.com/apache/tajo/pull/204

    TAJO-1124: RowWriter::putText and RowWriter::putBlob should take offset ...

    ...and length params.
    
    I added the proposed API and an unit test for the API.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hyunsik/tajo TAJO-1124

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #204
    
----
commit 58bc69d37ba24b365f43a87b0a509163d584a7fc
Author: Hyunsik Choi <[email protected]>
Date:   2014-10-19T06:28:54Z

    TAJO-1124: RowWriter::putText and RowWriter::putBlob should take offset and 
length params.

----


> RowWriter::putText and RowWriter::putBlob should take offset and length 
> params.
> -------------------------------------------------------------------------------
>
>                 Key: TAJO-1124
>                 URL: https://issues.apache.org/jira/browse/TAJO-1124
>             Project: Tajo
>          Issue Type: Improvement
>          Components: storage
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>            Priority: Minor
>             Fix For: block_iteration
>
>
> Currently, RowWriter support two methods for text and byte types as follows:
> {noformat}
> public void putText(byte [] val);
> public void putBlob(byte[] val);
> {noformat}
> In addition, we should support the followings:
> {noformat}
>  public void putText(byte [] val, int offset, int length);
>  public void putBlob(byte[] val, int offset, int length);
> {noformat}
> They would be very frequently used idioms for byte array.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to