[ 
https://issues.apache.org/jira/browse/TAJO-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183595#comment-14183595
 ] 

ASF GitHub Bot commented on TAJO-1109:
--------------------------------------

Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/201#issuecomment-60454535
  
    Hi @ykrips,
    
    Even though I'm not familiar with this approach, it definitely seems to 
make code cleaner as you mentioned in Jira. But, since I'm not familiar with 
it, I need more time to review it in more detail. It may take few days.
    
    Also, this patch seems to be stale gone. Could you rebase the patch?
    
    Thanks in advance


> Separate SQL Statements from Catalog Stores
> -------------------------------------------
>
>                 Key: TAJO-1109
>                 URL: https://issues.apache.org/jira/browse/TAJO-1109
>             Project: Tajo
>          Issue Type: Improvement
>          Components: catalog
>            Reporter: Jihun Kang
>            Assignee: Jihun Kang
>            Priority: Minor
>         Attachments: DBMSSchemaDefinition.xsd, derby.xml
>
>
> When developing the additional catalog stores for another database systems, 
> it is needed to add additional sql statements such as triggers and indexes. 
> These sql statements could increase the code size of catalog store, and when 
> database schema has changed, it may affect the catalog store source codes. I 
> feel that it is needed to separate the sql statements from the java source 
> codes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to