[
https://issues.apache.org/jira/browse/TAJO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183599#comment-14183599
]
ASF GitHub Bot commented on TAJO-1119:
--------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/208#issuecomment-60454791
The patch looks good to me.
But, this patch seems to omit the test to retrieve values. Could you add
more unit tests to get timestamp values from JDBC ResultSet?
> JDBC driver should support TIMESTAMP type.
> ------------------------------------------
>
> Key: TAJO-1119
> URL: https://issues.apache.org/jira/browse/TAJO-1119
> Project: Tajo
> Issue Type: Bug
> Components: client, JDBC
> Affects Versions: 0.8.0, 0.9.0
> Reporter: Hyunsik Choi
> Assignee: Jaehwa Jung
> Priority: Minor
>
> Currently, Tajo JDBC driver does not support TIMESTAMP type. When a user gets
> a TIMESTAMP value, the error is caused as follows:
> {noformat}
> org.apache.tajo.exception.UnsupportedException: Unrecognized column
> type:type: TIMESTAMP
> at
> org.apache.tajo.client.ResultSetUtil.toSqlType(ResultSetUtil.java:83)
> at
> org.apache.tajo.jdbc.TajoResultSetMetaData.getColumnTypeName(TajoResultSetMetaData.java:101)
> at
> com.gruter.taas.workbench.tajo.service.TajoService.getResultSetMetadata(TajoService.java:299)
> at
> com.gruter.taas.workbench.tajo.service.TajoService.getQueryResult(TajoService.java:384)
> at
> com.gruter.taas.workbench.tajo.service.TajoService.getQueryResult(TajoService.java:377)
> at
> com.gruter.taas.workbench.tajo.controller.TajoController.getQueryResult(TajoController.java:201)
> at sun.reflect.GeneratedMethodAccessor47.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.springframework.web.method.support.InvocableHandlerMethod.invoke(InvocableHandlerMethod.java:212)
> at
> org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:126)
> at
> org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:96)
> at
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:617)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
