[
https://issues.apache.org/jira/browse/TAJO-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209539#comment-14209539
]
ASF GitHub Bot commented on TAJO-1131:
--------------------------------------
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/232#discussion_r20280308
--- Diff:
tajo-plan/src/main/java/org/apache/tajo/plan/logical/SortNode.java ---
@@ -25,10 +25,16 @@
import org.apache.tajo.util.TUtil;
public final class SortNode extends UnaryNode implements Cloneable {
+ public static enum SortRangeType {
+ USING_SHUFFLE_DATA,
--- End diff --
It's just my suggestion. If you agree, please reflect my suggestion.
You seem to add SortRangeType in order to identify the purpose of SortNode.
```USING_STORAGE_MANAGER``` is for sorting rows for sorted HFiles of Hbase.
Otherwise, ```USING_SHUFFLE_DATA``` will be used. BTW, ```USING_SHUFFLE_DATA```
is used for shuffle as well as just sort. Even shuffle is also a part of
distributed sort. So, I think that this names probably gives some confuse to
code readers.
So, I'd like to suggest as follows:
* SortRangeType -> SORT_PURPOSE
* USING_SHUFFLE_DATA -> NORMAL
* USING_STORAGE_MANAGER -> STORAGE_SPECIFIED
As I mentioned earlier, it's just my suggestion.
> Supports Inserting or Creating table into the HBase mapped table.
> -----------------------------------------------------------------
>
> Key: TAJO-1131
> URL: https://issues.apache.org/jira/browse/TAJO-1131
> Project: Tajo
> Issue Type: Sub-task
> Reporter: Hyoungjun Kim
> Assignee: Hyoungjun Kim
> Priority: Minor
>
> Tajo should support inserting or creating table into the HBase mapped table.
> HBase supports bulk uploading. For using this tool the query result should
> be range partitioned and sorted by a region split range.
> See the following HBase reference.
> http://hbase.apache.org/book/arch.bulk.load.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
