[ 
https://issues.apache.org/jira/browse/TAJO-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214554#comment-14214554
 ] 

ASF GitHub Bot commented on TAJO-1177:
--------------------------------------

Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/243#issuecomment-63291935
  
    +1
    
    The patch looks good to me. It's nice work.
    
    TravisCI shows the compilation error. I may be caused by the log size 
limit. I fixed the problem in #245. I manually verified 'mvn clean install'. I 
passed all unit tests.


> Reduce the use of Sun proprietary API
> -------------------------------------
>
>                 Key: TAJO-1177
>                 URL: https://issues.apache.org/jira/browse/TAJO-1177
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Jihun Kang
>            Assignee: Jihun Kang
>            Priority: Minor
>
> Sometimes JVM developers tend to change their internal method signatures or 
> implementations for performance issues or design issues when upgrading 
> version of JVM. So if java class library provides public api for its 
> implementation, I think that using public api might be a good choice to avoid 
> compatibility issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to