[
https://issues.apache.org/jira/browse/TAJO-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222100#comment-14222100
]
ASF GitHub Bot commented on TAJO-1207:
--------------------------------------
GitHub user charsyam opened a pull request:
https://github.com/apache/tajo/pull/267
TAJO-1207: Remove redundant code in Bytes.java in tajo-common
in Bytes.java
padHead and padTail
Don't need to set array to 0.
because java alloc byte array and initialize them as 0.
```java
byte [] padding = new byte[length];
//so below is redundant block
for (int i = 0; i < length; i++)
{ padding[i] = 0; }
return add(padding,a);
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/charsyam/tajo feature/remove_code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #267
----
commit de6edbd2a0d39476582a0dc35c4a7b941d9d0300
Author: clark.kang <[email protected]>
Date: 2014-11-22T18:07:02Z
remove unnessary code
----
> Remove redundant code in Bytes.java in tajo-common
> --------------------------------------------------
>
> Key: TAJO-1207
> URL: https://issues.apache.org/jira/browse/TAJO-1207
> Project: Tajo
> Issue Type: Improvement
> Reporter: DaeMyung Kang
> Assignee: DaeMyung Kang
> Priority: Trivial
>
> in Bytes.java
> padHead and padTail
> Don't need to set array to 0.
> because java alloc byte array and initialize them as 0.
> ```java
> byte [] padding = new byte[length];
> //so below is redundant block
> for (int i = 0; i < length; i++) {
> padding[i] = 0;
> }
> return add(padding,a);
> ```
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
