Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/231#discussion_r20972931
--- Diff: tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
---
@@ -458,39 +474,49 @@ public QueryId updateQuery(QueryContext queryContext,
String sql, boolean isJson
}
private boolean updateQuery(QueryContext queryContext, LogicalNode root)
throws IOException {
-
+ boolean requireForward = false;
switch (root.getType()) {
case CREATE_DATABASE:
CreateDatabaseNode createDatabase = (CreateDatabaseNode) root;
createDatabase(queryContext, createDatabase.getDatabaseName(),
null, createDatabase.isIfNotExists());
- return true;
+ break;
case DROP_DATABASE:
DropDatabaseNode dropDatabaseNode = (DropDatabaseNode) root;
dropDatabase(queryContext, dropDatabaseNode.getDatabaseName(),
dropDatabaseNode.isIfExists());
- return true;
+ break;
case CREATE_TABLE:
CreateTableNode createTable = (CreateTableNode) root;
createTable(queryContext, createTable,
createTable.isIfNotExists());
- return true;
+ break;
case DROP_TABLE:
DropTableNode dropTable = (DropTableNode) root;
dropTable(queryContext, dropTable.getTableName(),
dropTable.isIfExists(), dropTable.isPurge());
- return true;
+ break;
case ALTER_TABLESPACE:
AlterTablespaceNode alterTablespace = (AlterTablespaceNode) root;
alterTablespace(queryContext, alterTablespace);
- return true;
+ break;
case ALTER_TABLE:
AlterTableNode alterTable = (AlterTableNode) root;
alterTable(queryContext,alterTable);
- return true;
+ break;
case TRUNCATE_TABLE:
TruncateTableNode truncateTable = (TruncateTableNode) root;
truncateTable(queryContext, truncateTable);
- return true;
+ break;
+ case CREATE_INDEX:
+ CreateIndexNode createIndexNode = (CreateIndexNode) root;
+ createIndex(queryContext, createIndexNode);
+ requireForward = true;
+ break;
+ case DROP_INDEX:
+ DropIndexNode dropIndexNode = (DropIndexNode) root;
+ dropIndex(queryContext, dropIndexNode);
+ break;
default:
throw new InternalError("updateQuery cannot handle such query: \n"
+ root.toJson());
}
+ return requireForward;
--- End diff --
The behavior of ```updateQuery``` seems to be changed. Could you add
comment about updateQuery metnod?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
